Doctrine 2 - ORM

Doctrine thrown exception, when it is trying to remove not initialized proxy.

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-ALPHA4
  • Fix Version/s: 2.0-BETA1
  • Component/s: None
  • Security Level: All
  • Labels:
    None

Description

Introduction:
I have a Product, which has many (OneToMany collection) Pictures. Picture has a File (ManyToOne with cascade=

{"remove", "persist"}

).
The problem:
When I remove a picture from a product 

$product->pictures->removeElement($picture);
$picture->resetProduct();

doctrine removes picture, then cascade removes file, but file is not yet initialized. Doctrine tries to check entity state:

    public function getEntityState($entity, $assume = null)
    {
        $oid = spl_object_hash($entity);
        if ( ! isset($this->_entityStates[$oid])) {
...
            if ($assume === null) {
                if ($this->_em->getClassMetadata(get_class($entity))->getIdentifierValues($entity)) {
                    $this->_entityStates[$oid] = self::STATE_DETACHED;
...

The getIdentifierValues method tries to take entity id through reflection, but id field is absent.
I think that the getEntityState method should support case when entity is instance of IProxy...

  1. File
    doctrine2test.rar
    26/Feb/10 4:20 AM
    27 kB
    Valery Dubrava
  2. File
    DDC353Test.php
    28/Feb/10 8:50 AM
    4 kB
    Benjamin Eberlei

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Valery Dubrava added a comment -

May be I'm wrong, but as workaround I made the following:
1. Added a _load method to Proxy interface (why it is not called IProxy?)
2. Made the _load method public (in ProxyFactory)
3. Added another one case to getEntityState method:

            if ($entity instanceof \Doctrine\ORM\Proxy\Proxy) {
                $entity->_load();
            } elseif ($assume === null) {
Show
Valery Dubrava added a comment - May be I'm wrong, but as workaround I made the following: 1. Added a _load method to Proxy interface (why it is not called IProxy?) 2. Made the _load method public (in ProxyFactory) 3. Added another one case to getEntityState method: if ($entity instanceof \Doctrine\ORM\Proxy\Proxy) { $entity->_load(); } elseif ($assume === null) {
Hide
Permalink
Roman S. Borschel added a comment -

What is the error/exception you are getting? Please show the full stack trace in case of an exception.

Show
Roman S. Borschel added a comment - What is the error/exception you are getting? Please show the full stack trace in case of an exception.
Hide
Permalink
Roman S. Borschel added a comment -

This code:

$product->pictures->removeElement($picture);
$picture->resetProduct();

will only remove the association, not the picture or the file, thus remove cascades would not even apply.

Show
Roman S. Borschel added a comment - This code: $product->pictures->removeElement($picture); $picture->resetProduct(); will only remove the association, not the picture or the file, thus remove cascades would not even apply.
Hide
Permalink
Roman S. Borschel added a comment -

Please show the full code you're using (models etc.) and the error or unexpected behavior you're getting, so that we can try to reproduce it.

Show
Roman S. Borschel added a comment - Please show the full code you're using (models etc.) and the error or unexpected behavior you're getting, so that we can try to reproduce it.
Hide
Permalink
Valery Dubrava added a comment -

It will take many time, because my project has a huge infrastructure. I write when I reproduce it in console.

Show
Valery Dubrava added a comment - It will take many time, because my project has a huge infrastructure. I write when I reproduce it in console.
Hide
Permalink
Valery Dubrava added a comment -

I have attached test project in which I reproduced this problem.
What I did:
1. I created schema manually (user create.sql file)
2. I generated model classes (by doctrine-cli.php script)
3. Made a little changes in annotations (I just added OneToMany between product and picture)
4. Run script pictest.php
Steps for reproducing:
1. create schema from create.sql file
2. fix connection string in dbconfig.php
3. run pictest.sql

Show
Valery Dubrava added a comment - I have attached test project in which I reproduced this problem. What I did: 1. I created schema manually (user create.sql file) 2. I generated model classes (by doctrine-cli.php script) 3. Made a little changes in annotations (I just added OneToMany between product and picture) 4. Run script pictest.php Steps for reproducing: 1. create schema from create.sql file 2. fix connection string in dbconfig.php 3. run pictest.sql
Hide
Permalink
Benjamin Eberlei added a comment -

Please create a unit-test, in the schema of tests\Doctrine\Tests\ORM\Functional\Ticket and attach it as a .patch or .diff or .php file. This is not a minimal re-produce case that can be easily understood or run by us.

Show
Benjamin Eberlei added a comment - Please create a unit-test, in the schema of tests\Doctrine\Tests\ORM\Functional\Ticket and attach it as a .patch or .diff or .php file. This is not a minimal re-produce case that can be easily understood or run by us.
Hide
Permalink
Valery Dubrava added a comment -

Could you please provide some kind of documentation (or link to it) on how to create such unit tests.
I understand, that my test enviroment is not convenient for you, but it countains only initialization code and issue code. It's a minimal code which required for reproducing. If you spend a little time, you would see...

Show
Valery Dubrava added a comment - Could you please provide some kind of documentation (or link to it) on how to create such unit tests. I understand, that my test enviroment is not convenient for you, but it countains only initialization code and issue code. It's a minimal code which required for reproducing. If you spend a little time, you would see...
Hide
Permalink
Benjamin Eberlei added a comment -

Verified, attached the testcase

@Valery: The attached file shows the test-case for your behaviour, its a stripped down 200 lines php file compared to your 30kb rar file

Show
Benjamin Eberlei added a comment - Verified, attached the testcase @Valery: The attached file shows the test-case for your behaviour, its a stripped down 200 lines php file compared to your 30kb rar file
Hide
Permalink
Benjamin Eberlei added a comment - - edited

The problem is easily explained:

Reference / Proxy objects are not marked as MANAGED in the UnitOfWork if they are initialized through a hydrator compared to calling `getReference()`

Show
Benjamin Eberlei added a comment - - edited The problem is easily explained: Reference / Proxy objects are not marked as MANAGED in the UnitOfWork if they are initialized through a hydrator compared to calling `getReference()`
Hide
Permalink
Benjamin Eberlei added a comment -

Updated test-case that shows when it works, when it fails.

Show
Benjamin Eberlei added a comment - Updated test-case that shows when it works, when it fails.
Hide
Permalink
Benjamin Eberlei added a comment -

Fixed

Show
Benjamin Eberlei added a comment - Fixed
Hide
Permalink
Valery Dubrava added a comment -

Thanks for the fix!
@Benjamin Eberlei: I see. But know nothing about how you are writing a test-cases. May be it would be useful to provide documentation (simple instruction) about it.Possible, then my experience will bring a little more benefits for you..

Show
Valery Dubrava added a comment - Thanks for the fix! @Benjamin Eberlei: I see. But know nothing about how you are writing a test-cases. May be it would be useful to provide documentation (simple instruction) about it.Possible, then my experience will bring a little more benefits for you..

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Valery Dubrava
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: