Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-3239

[GH-1097] `expandParameters`/`getType` in BasicEntityPersister seems to really cover just few cases

    Details

      Description

      This issue is created automatically through a Github pull request on behalf of kamazee:

      Url: https://github.com/doctrine/doctrine2/pull/1097

      Message:

      The test case below seems fairly simple, but I believe that it might uncover a bigger issue.

      It seems odd that [`getType` (and, hence, `expandParameters`)](https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Persisters/BasicEntityPersister.php#L1731-1795) in BasicEntityPersister clearly expects field name but often gets different things.

      Just set a breakpoint there and watch values through the test suite. There might be not just field name, but a column with alias as well. This works:
      ![screenshot from 2014-08-01 14 03 44](https://cloud.githubusercontent.com/assets/231518/3778796/c5cc3e66-1979-11e4-9279-5c322b7e8402.png)

      But this, apparently, doesn't:
      ![screenshot from 2014-08-01 14 07 29](https://cloud.githubusercontent.com/assets/231518/3778816/20da192c-197a-11e4-90b4-4c37ee454fb6.png)

      There are multiple places (more than one) that call `expandParameters` with criteria that can't be resolved with `getType`. Is this situation expected or worth further investigation/fixing?

        Issue Links

          Activity

          Hide
          Marco Pivetta added a comment -

          Handled in DDC-3380

          Show
          Marco Pivetta added a comment - Handled in DDC-3380
          Hide
          Doctrine Bot added a comment -

          A related Github Pull-Request [GH-1097] was labeled:
          https://github.com/doctrine/doctrine2/pull/1097

          Show
          Doctrine Bot added a comment - A related Github Pull-Request [GH-1097] was labeled: https://github.com/doctrine/doctrine2/pull/1097
          Hide
          Doctrine Bot added a comment -

          A related Github Pull-Request [GH-1097] was labeled:
          https://github.com/doctrine/doctrine2/pull/1097

          Show
          Doctrine Bot added a comment - A related Github Pull-Request [GH-1097] was labeled: https://github.com/doctrine/doctrine2/pull/1097
          Hide
          Doctrine Bot added a comment -

          A related Github Pull-Request [GH-1097] was assigned:
          https://github.com/doctrine/doctrine2/pull/1097

          Show
          Doctrine Bot added a comment - A related Github Pull-Request [GH-1097] was assigned: https://github.com/doctrine/doctrine2/pull/1097
          Hide
          Doctrine Bot added a comment -

          A related Github Pull-Request [GH-1097] was closed:
          https://github.com/doctrine/doctrine2/pull/1097

          Show
          Doctrine Bot added a comment - A related Github Pull-Request [GH-1097] was closed: https://github.com/doctrine/doctrine2/pull/1097

            People

            • Assignee:
              Marco Pivetta
              Reporter:
              Doctrine Bot
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: