Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.4.4
    • Component/s: ORM
    • Security Level: All

      Description

      DDC-3160 should be backported to 2.4.4 once user feedback is collected.

        Issue Links

          Activity

          Hide
          Kevin Bond added a comment -

          I ran the DoctrineExtensions test suite with ORM 2.4 with this fix and it passed.

          Show
          Kevin Bond added a comment - I ran the DoctrineExtensions test suite with ORM 2.4 with this fix and it passed.
          Hide
          Justin Zimmerman added a comment - - edited

          For the project I was working on where I started having issues with the 2.4.3 update and Atlantic18/DoctrineExtensions, the DDC-3160 solution did fix the problems that I was seeing. Granted, I am only using the Tree portion of that library, I cannot say anything about the other parts of it.

          I just ran a test with the latest DoctrineExtensions code. These are the results I get with running Doctrine 2.4.3:

          FAILURES!
          Tests: 411, Assertions: 1760, Errors: 71, Skipped: 62.

          When I patch up the Doctrine 2.4.3 branch with the DDC-3160 fix, I get much better results:

          OK, but incomplete, skipped, or risky tests!
          Tests: 411, Assertions: 2410, Skipped: 62.

          From what I can tell, this does seem to fix the DoctrineExtensions issues which I believe was eventually tracked down to being caused by the DDC-2996 fix.

          Show
          Justin Zimmerman added a comment - - edited For the project I was working on where I started having issues with the 2.4.3 update and Atlantic18/DoctrineExtensions, the DDC-3160 solution did fix the problems that I was seeing. Granted, I am only using the Tree portion of that library, I cannot say anything about the other parts of it. I just ran a test with the latest DoctrineExtensions code. These are the results I get with running Doctrine 2.4.3: FAILURES! Tests: 411, Assertions: 1760, Errors: 71, Skipped: 62. When I patch up the Doctrine 2.4.3 branch with the DDC-3160 fix, I get much better results: OK, but incomplete, skipped, or risky tests! Tests: 411, Assertions: 2410, Skipped: 62. From what I can tell, this does seem to fix the DoctrineExtensions issues which I believe was eventually tracked down to being caused by the DDC-2996 fix.
          Hide
          Eric Coleman added a comment -

          Patch is working for us.

          Show
          Eric Coleman added a comment - Patch is working for us.
          Hide
          Marco Pivetta added a comment -

          Going to merge this back into 2.4.x asap

          Show
          Marco Pivetta added a comment - Going to merge this back into 2.4.x asap
          Show
          Marco Pivetta added a comment - Merged at https://github.com/doctrine/doctrine2/commit/5c5abb6771c1f5ab8318f76aed79ce1da8a0300d

            People

            • Assignee:
              Marco Pivetta
              Reporter:
              Marco Pivetta
            • Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved: