Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-3198

[GH-1075] Fixed query cache id generation: added platform to hash

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of vilartoni:

      Url: https://github.com/doctrine/doctrine2/pull/1075

      Message:

      There's an issue with the query cache id generation in `Doctrine\ORM\Query::_getQueryCacheId()`.

      If you happen to use different connections to different platforms on the same project and you're using the query cache, you will get an exception the moment you try to execute a query which SQL is different depending on the platform and it has been previously cached for the other platform, as they will share the same cache id.

      In order to reproduce the bug it is sufficient with using the Doctrine Paginator in a query:

      ```
      $query = $queryBuilder->setFirstResult(0)
      ->setMaxResults(50)
      ->getQuery()
      ->getResult();
      ```

      If we run the query for the first time with an empty cache in an Oracle connection and later on we try to run the same query in a MySQL connection, we get the following exception:

      ```
      SQLSTATE[42S22]: Column not found: 1054 Unknown column 'ROWNUM' in 'where clause'
      ```

      As it's trying to execute the SQL for Oracle in the MySQL connection due to the same cache id.

      This issue can be easily fixed just by taking the platform type into account in the cache id generation.

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-1075] was closed:
        https://github.com/doctrine/doctrine2/pull/1075

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-1075] was closed: https://github.com/doctrine/doctrine2/pull/1075
        Show
        Marco Pivetta added a comment - Merged: https://github.com/doctrine/doctrine2/commit/c370426792edda8290843e601e9f95d86a7e873f

          People

          • Assignee:
            Marco Pivetta
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: