Doctrine 2 - ORM

YAML-Driver does not support hasLifecycleCallbacks

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-ALPHA4
  • Fix Version/s: 2.0-BETA1
  • Component/s: None
  • Security Level: All
  • Labels:
    None

Description

Although the annotation driver does, the YAML-Driver does not.

Any idea how to access the ancestor's yamlfile? I'd probably have to get an instance of the entity first, perform reflection on it, find the superclass, get it's yaml file (if there is any) and repeat this until we've reached the top of the inheritance hierarchy...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Eberlei added a comment -

I dont really understand, you don't need @hasLifecycleCallbacks, you just define a section "lifecycleCallbacks" in your yaml file.

see the documentation o rtests/Doctrine/Tests/ORM/Mapping/Driver for an example yaml file. It should work out of the box.

Show
Benjamin Eberlei added a comment - I dont really understand, you don't need @hasLifecycleCallbacks, you just define a section "lifecycleCallbacks" in your yaml file. see the documentation o rtests/Doctrine/Tests/ORM/Mapping/Driver for an example yaml file. It should work out of the box.
Hide
Permalink
Christian Heinrich added a comment -

I actually intended to use inheritance for the lifecycle callbacks. This is currently not working for YAML, and as far as I know, the @has... is used within the annotations to achieve exactly this.

Show
Christian Heinrich added a comment - I actually intended to use inheritance for the lifecycle callbacks. This is currently not working for YAML, and as far as I know, the @has... is used within the annotations to achieve exactly this.
Hide
Permalink
Christian Heinrich added a comment -

(The inheritance not working implies that you have to specify your lifecycleCallbacks in each (derived) entity that is supposed to use these either)

Show
Christian Heinrich added a comment - (The inheritance not working implies that you have to specify your lifecycleCallbacks in each (derived) entity that is supposed to use these either)
Hide
Permalink
Roman S. Borschel added a comment -

Yes, in annotations it currently "works" if you put @HasLifecycleCallbacks on the derived class. However, this is not how it should be and lifecycle callbacks should be inherited automatically from mapped parent classes to mapped child classes.

This does not affect the mapping drivers, this rather needs to be addressed in the ClassMetadataFactory I think. Fixing this should be fairly trivial. I think there is even already a ticket about this issue.

Show
Roman S. Borschel added a comment - Yes, in annotations it currently "works" if you put @HasLifecycleCallbacks on the derived class. However, this is not how it should be and lifecycle callbacks should be inherited automatically from mapped parent classes to mapped child classes. This does not affect the mapping drivers, this rather needs to be addressed in the ClassMetadataFactory I think. Fixing this should be fairly trivial. I think there is even already a ticket about this issue.
Hide
Permalink
Roman S. Borschel added a comment -

This should now work properly, for all XML, YAML and annotations. For annotations it means @HasLifecycleCallbacks is no longer required on the subclass if the subclass does not define any new callback methods.

Show
Roman S. Borschel added a comment - This should now work properly, for all XML, YAML and annotations. For annotations it means @HasLifecycleCallbacks is no longer required on the subclass if the subclass does not define any new callback methods.
Roman S. Borschel made changes -
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s 2.0-BETA1 [ 10030 ]
Resolution Fixed [ 1 ]
Benjamin Eberlei made changes -
Workflow jira [ 10857 ] jira-feedback [ 15543 ]
Benjamin Eberlei made changes -
Workflow jira-feedback [ 15543 ] jira-feedback2 [ 17407 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 17407 ] jira-feedback3 [ 19664 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-311, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Roman S. Borschel
    Reporter:
    Christian Heinrich
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: