Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-3114

[GH-1026] Remove some redundant clauses

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of flack:

      Url: https://github.com/doctrine/doctrine2/pull/1026

      Message:

      The objectmanager insertion logic was identical in the if and else clauses, so I replaced both occurences with one directly after the else block closes. It is semantically identical but a little more readable, especially since the method has more than 250 lines (and a cyclomatic complexity of 100 or so ) as it is.

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-1026] was closed:
        https://github.com/doctrine/doctrine2/pull/1026

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-1026] was closed: https://github.com/doctrine/doctrine2/pull/1026
        Show
        Marco Pivetta added a comment - Merged: https://github.com/doctrine/doctrine2/commit/94837a0105eec91f572ef18dc140779586f931a6

          People

          • Assignee:
            Marco Pivetta
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: