Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of KamilKopaczyk:

      Url: https://github.com/doctrine/doctrine2/pull/993

      Message:

      If $referencedColumnName = 'id' by default, it doesn't make sense to make checks like:
      ```php
      if (empty($joinColumn['referencedColumnName'])) {
      ```
      (ClassMetaDataInfo file)


      Considering you map your column
      ```
      @ORM\JoinColumn(onDelete="CASCADE")
      ```
      You'll get JoinColumn with 'id' value, which doesn't let doctrine use naming strategies for referenced column names

        Activity

        Doctrine Bot created issue -
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-993] was closed:
        https://github.com/doctrine/doctrine2/pull/993

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-993] was closed: https://github.com/doctrine/doctrine2/pull/993
        Hide
        Guilherme Blanco added a comment -

        Unfortunately, while this is true for Annotations (it can never be empty), it is not for XML, YAML and PHP itself.
        When using Annotations, we keep convention over configuration as the standard, providing the default id, while we require further configuration on other drivers.

        Closing as invalid.

        Show
        Guilherme Blanco added a comment - Unfortunately, while this is true for Annotations (it can never be empty), it is not for XML, YAML and PHP itself. When using Annotations, we keep convention over configuration as the standard, providing the default id, while we require further configuration on other drivers. Closing as invalid.
        Guilherme Blanco made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Benjamin Eberlei [ beberlei ] Guilherme Blanco [ guilhermeblanco ]
        Fix Version/s 2.5 [ 10522 ]
        Resolution Invalid [ 6 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-3058, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Guilherme Blanco
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: