Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-2790

[GH-845] Don't compute changeset for entities that are going to be deleted

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of flack:

      Url: https://github.com/doctrine/doctrine2/pull/845

      Message:

      This is somewhat related to

      http://www.doctrine-project.org/jira/browse/DDC-2761

      I'm not sure if it fixes that particular problem, but it certainly helps with some unrelated issues I'm seeing in my code. My theory is that doctrine doesn't even need to compute changesets when an entity is scheduled to be removed, because all that would accomplish is to insert an UPDATE statement immediately before the DELETE statement for the entity.

      The test suite passes, but I have not added a test specifically for this change (mostly because I wouldn't know exactly what to test). I could try to create one if necessary, though

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-845] was closed:
        https://github.com/doctrine/doctrine2/pull/845

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-845] was closed: https://github.com/doctrine/doctrine2/pull/845
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-829] was closed:
        https://github.com/doctrine/doctrine2/pull/829

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-829] was closed: https://github.com/doctrine/doctrine2/pull/829

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: