Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-2761

[GH-828] Fixed UnitOfWork::recomputeSingleEntityChangeSet exception with STATE_REMOVED entities

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Incomplete
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of giosh94mhz:

      Url: https://github.com/doctrine/doctrine2/pull/828

      Message:

      Hi!

      I found a bug in UnitOfWork::recomputeSingleEntityChangeSet for the branch 2.4. I didn't tested master and previous version, but the bug may also apply.

      The problem is that an exception is thrown on flush (at least when using a single entity flush), if an entity is in deleted state and also with pending modification and a preUpdate listener configured.

      I've attached a patch and a unit tests (I've tweeked a previous preUpdate method used for testing, but everythings pass).

      Anyway, this result in an UPDATE followed by a DELETE statement. I think also that an entity in STATE_REMOVED don't need to be updated, and should be immediately deleted. If you agree, I could implement it myself (as long I manage not to break unit tests).

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-828] was closed:
        https://github.com/doctrine/doctrine2/pull/828

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-828] was closed: https://github.com/doctrine/doctrine2/pull/828

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: