Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-2685

[GH-793] Improved error messages in Paginator: LimitSubqueryOutputWalker

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of flip111:

      Url: https://github.com/doctrine/doctrine2/pull/793

      Message:

      The already existing follow-up check throwing "Not all identifier properties can be found in the ResultSetMapping: %s" is a much more technical description.

      If $sqlIdentifier is empty (count 0) it can be concluded that there are no mapped results. An alternative error message could thus be "The Paginator does not support queries without mapped results." (line 153).

      Possibly '!=' on line 154 could be replaced by '>' because i think this is the only situation that can occur. But since i don't know this for sure, i left it like i found it.

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-793] was closed:
        https://github.com/doctrine/doctrine2/pull/793

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-793] was closed: https://github.com/doctrine/doctrine2/pull/793
        Show
        Marco Pivetta added a comment - Merged: https://github.com/doctrine/doctrine2/commit/d8335eee7b1e8e8c3bdd11c30d81fe96d80f4510

          People

          • Assignee:
            Guilherme Blanco
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: