Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-2589

[GH-746] Makes children of AbstractQuery non-final.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of elyobo:

      Url: https://github.com/doctrine/doctrine2/pull/746

      Message:

      b66d530540d18c60720e1843fc65ce7e0399a71c made these classes final, but there is no rationale for this change given in the commit log. Leaving this as final makes it impossible to mock and makes testing some areas of code difficult (or impossible).

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-746] was closed:
        https://github.com/doctrine/doctrine2/pull/746

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-746] was closed: https://github.com/doctrine/doctrine2/pull/746
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-746] was closed:
        https://github.com/doctrine/dbal/pull/746

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-746] was closed: https://github.com/doctrine/dbal/pull/746
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-746] was assigned:
        https://github.com/doctrine/dbal/pull/746

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-746] was assigned: https://github.com/doctrine/dbal/pull/746

          People

          • Assignee:
            Marco Pivetta
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: