Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-2472

[GH-677] Type fix in ORM\PersistentCollection

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of michaldudek:

      Url: https://github.com/doctrine/doctrine2/pull/677

      Message:

      The ```ORM\PersistentCollection``` class accepts anything as 3rd argument to its constructor while it should be either array or ```Collection``` object. The ```$this->coll``` phpdoc says that it's a ```Collection``` while the constructor's phpdoc says it's an array.

      The class assumes ```Collection``` but there isn't any type check at all. I have added conversion of array into ```ArrayCollection``` in the constructor as in some (very unclear) cases it likes to die with a fatal error:

      ```Fatal error: Call to a member function add() on a non-object in Doctrine/ORM/PersistentCollection.php on line 169```

        Activity

        Doctrine Bot created issue -
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-677] was closed:
        https://github.com/doctrine/doctrine2/pull/677

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-677] was closed: https://github.com/doctrine/doctrine2/pull/677
        Benjamin Eberlei made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Invalid [ 6 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-2472, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: