Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-2310

Recent changes to DBAL SQL Server platform lock hinting breaks ORM SqlWalker in DQL queries with joins

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: Git Master
    • Fix Version/s: 2.3.3, 2.5
    • Component/s: ORM
    • Security Level: All
    • Environment:
      SQL Server

      Description

      The SQL Server platform throws an error when you try to run DQL with JOIN statements.

      The breaking change was in the DBAL SQL Server platform – it was changed to add a ' WITH (NOLOCK)' to the appendLockHint function. Change was in this rev. The change in DBAL is not wrong, it just highlighted the bug in the ORM...

      The ORM SqlWalker runs the appendLockHint function against a generated FROM / JOIN clause in the walkFromClause func here. This is actually the wrong place to append lock hints. This is generating the FROM clause like:

       FROM foo f0_ LEFT JOIN foo_bar f1_ ON f0_.id = f1_.foo_id LEFT JOIN bar b2_ ON f1_.bar_id = b2_.id WITH (NOLOCK)

      When it should actually generate something like:

       FROM foo f0_ WITH (NOLOCK) LEFT JOIN foo_bar f1_ WITH (NOLOCK) ON f0_.id = f1_.foo_id LEFT JOIN bar b2_ WITH (NOLOCK) ON f1_.bar_id = b2_.id

      It should append lock hints after the table alias.

      I think the only reason this hasn't shown up before is that the other lock hint types haven't been applied in this way before, if at all.

        Issue Links

          Activity

          Hide
          Steve Müller added a comment -
          Show
          Steve Müller added a comment - Benjamin Eberlei It is fixed in PR: https://github.com/doctrine/doctrine2/pull/910
          Hide
          Benjamin Eberlei added a comment -

          Steve Müller When is it?

          Show
          Benjamin Eberlei added a comment - Steve Müller When is it?
          Hide
          Doctrine Bot added a comment -

          A related Github Pull-Request [GH-910] was closed:
          https://github.com/doctrine/doctrine2/pull/910

          Show
          Doctrine Bot added a comment - A related Github Pull-Request [GH-910] was closed: https://github.com/doctrine/doctrine2/pull/910
          Hide
          Steve Müller added a comment -

          This is not resolved, yet.

          Show
          Steve Müller added a comment - This is not resolved, yet.
          Hide
          Doctrine Bot added a comment -

          A related Github Pull-Request [GH-508] was closed:
          https://github.com/doctrine/dbal/pull/508

          Show
          Doctrine Bot added a comment - A related Github Pull-Request [GH-508] was closed: https://github.com/doctrine/dbal/pull/508
          Hide
          Steve Müller added a comment -

          Complementary I provided the following patch to suppress unnecessary NOLOCK hint generation in ORM: https://github.com/doctrine/dbal/pull/508

          Show
          Steve Müller added a comment - Complementary I provided the following patch to suppress unnecessary NOLOCK hint generation in ORM: https://github.com/doctrine/dbal/pull/508
          Hide
          Steve Müller added a comment -

          I don't know why this ticket is marked as "fixed" because it's obviously NOT.
          Whatever, here is the patch: https://github.com/doctrine/doctrine2/pull/910

          Show
          Steve Müller added a comment - I don't know why this ticket is marked as "fixed" because it's obviously NOT. Whatever, here is the patch: https://github.com/doctrine/doctrine2/pull/910
          Hide
          William Schaller added a comment -

          @Christophe I considered that too. None of the other platforms implement the appendLockHint function. None of the other platforms implement this because it is handled differently on other platforms – with transaction isolation levels and such.

          Show
          William Schaller added a comment - @Christophe I considered that too. None of the other platforms implement the appendLockHint function. None of the other platforms implement this because it is handled differently on other platforms – with transaction isolation levels and such.
          Hide
          Christophe Coevoet added a comment -

          I think the line appending the lock should be moved to this place to achieve the result displayed above.

          But it may cause issues with some other vendor.

          Show
          Christophe Coevoet added a comment - I think the line appending the lock should be moved to this place to achieve the result displayed above. But it may cause issues with some other vendor.

            People

            • Assignee:
              Benjamin Eberlei
              Reporter:
              William Schaller
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: