Doctrine 2 - ORM

YAML isn't persisting correcty

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Invalid
  • Affects Version/s: 2.0-ALPHA3
  • Fix Version/s: None
  • Component/s: None
  • Security Level: All
  • Labels:
    None
  • Environment:

Description

I'm have some problems when I try to persist..
I've created these classes:

class Customer
{
    public $id;
    public $users;

    public function __construct()
    {
        $this->users = new \Doctrine\Common\Collections\ArrayCollection();
    }
}

class User
{
    public $id;
    public $customer;
}

And then I make the mappers with YAML

Ciutat\DomainModel\Customer:
  type: entity
  table: customer
  fields:
    id:
      type: integer
      id: true
      generator:
        strategy: auto
      sequenceGenerator:
        sequenceName: customer_id_seq
        allocationSize: 1
        initialValue: 1
  oneToMany:
    users:
      targetEntity: User
      mappedBy: customer
      cascade: cascadePersist

Ciutat\DomainModel\User:
  type: entity
  table: user1
  fields:
    id:
      type: integer
      id: true
      generator:
        strategy: auto
      sequenceGenerator:
        sequenceName: user1_id_seq
        allocationSize: 1
        initialValue: 1
  manyToOne:
    customer:
      targetEntity: Customer
      joinColumn:
        name: customerId
        referencedColumnName: id

And when I try to persist some data

$costumer = new DomainModel\Customer();
$user = new DomainModel\User();
$user2 = new DomainModel\User();
$user3 = new DomainModel\User();

$costumer->users->add($user);
$costumer->users->add($user2);
$costumer->users->add($user3);
    
$em->persist($costumer);
$em->flush();

the result in my database is not what I think it must be expected

select * from customer;
 id 
----
  1

elect * from user1;
 id | customerid 
----+------------
  1 |           
  2 |           
  3 |

I would like to know if have some mistake with my code or is there a problem with YAML? 'cause I think there should be some data on 'customerId', don't I ?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roman S. Borschel added a comment -

This is expected behavior. You must maintain the bidirectional association properly. Doctrine only looks at the "owning side" of a bidirectional association. In the case of a bidirectional one-to-many, like in your case, the owning side is always the many-side. Since you only add the elements to the collection, but dont set the customer property pointing back to the customer, the association does not exist for Doctrine.

Change your code to:

$costumer = new DomainModel\Customer();
$user = new DomainModel\User();
$user2 = new DomainModel\User();
$user3 = new DomainModel\User();

$costumer->users->add($user);
$user->customer = $costumer;
$costumer->users->add($user2);
$user2->customer = $costumer;
$costumer->users->add($user3);
$user3->customer = $costumer;

$em->persist($costumer);
$em->flush();

And it should work.

Please read this section carefully: http://www.doctrine-project.org/documentation/manual/2_0/en/association-mapping#owning-side-and-inverse-side

Its a simple, yet essential concept to understand.

Hope that helps.

Show
Roman S. Borschel added a comment - This is expected behavior. You must maintain the bidirectional association properly. Doctrine only looks at the "owning side" of a bidirectional association. In the case of a bidirectional one-to-many, like in your case, the owning side is always the many-side. Since you only add the elements to the collection, but dont set the customer property pointing back to the customer, the association does not exist for Doctrine. Change your code to: $costumer = new DomainModel\Customer(); $user = new DomainModel\User(); $user2 = new DomainModel\User(); $user3 = new DomainModel\User(); $costumer->users->add($user); $user->customer = $costumer; $costumer->users->add($user2); $user2->customer = $costumer; $costumer->users->add($user3); $user3->customer = $costumer; $em->persist($costumer); $em->flush(); And it should work. Please read this section carefully: http://www.doctrine-project.org/documentation/manual/2_0/en/association-mapping#owning-side-and-inverse-side Its a simple, yet essential concept to understand. Hope that helps.
Hide
Permalink
Henrique Girardi dos Santos added a comment -

I did this way sometime ago but I thought I was a mistake mine..but I see i was correct..
I created a prePersist method where I did it automatic and a postPersist to unset after that, cause I dont see any another reason to keep all my object customer inside the User class if inside Customer I have a User collection, so I know which Users belong to Customer..

why I need to set 

oneToMany:
    users:
      targetEntity: User
      mappedBy: customer
      cascade: cascadePersist

in Customer?? I thought if I set the target and the mappedBy it would be enough..can't it be automatic? Or it's impossible?

Show
Henrique Girardi dos Santos added a comment - I did this way sometime ago but I thought I was a mistake mine..but I see i was correct.. I created a prePersist method where I did it automatic and a postPersist to unset after that, cause I dont see any another reason to keep all my object customer inside the User class if inside Customer I have a User collection, so I know which Users belong to Customer.. why I need to set oneToMany: users: targetEntity: User mappedBy: customer cascade: cascadePersist in Customer?? I thought if I set the target and the mappedBy it would be enough..can't it be automatic? Or it's impossible?
Hide
Permalink
Roman S. Borschel added a comment -

You dont need prePersist or postPersist. You just need to maintain your bidirectional associations properly. This is nothing doctrine specific, basic OOP.

And it is not automatic because this would break transparency. Its not the task of the ORM to fix your broken associations. Then your object model is suddenly broken without the persistence layer.

If you want a unidirectional one-to-many, you must map it through a join table. Its all in the documentation.

The behavior is very consistent and predictable (compared to what D1 does, for example...)

Show
Roman S. Borschel added a comment - You dont need prePersist or postPersist. You just need to maintain your bidirectional associations properly. This is nothing doctrine specific, basic OOP. And it is not automatic because this would break transparency. Its not the task of the ORM to fix your broken associations. Then your object model is suddenly broken without the persistence layer. If you want a unidirectional one-to-many, you must map it through a join table. Its all in the documentation. The behavior is very consistent and predictable (compared to what D1 does, for example...)
Hide
Permalink
Henrique Girardi dos Santos added a comment -

I know I dont need prePersist or postPersist, It was just my choice, I just created them to make it automaticaly..
and I don't want a unidirectional..there's no reason to have another table to join them..
but now I understood why it's not automatic..

thanks man!

Show
Henrique Girardi dos Santos added a comment - I know I dont need prePersist or postPersist, It was just my choice, I just created them to make it automaticaly.. and I don't want a unidirectional..there's no reason to have another table to join them.. but now I understood why it's not automatic.. thanks man!

People

  • Assignee:
    Roman S. Borschel
    Reporter:
    Henrique Girardi dos Santos
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: