Doctrine 2 - ORM

@param wrong in Doctrine\ORM\PersistentCollection::__constructor Edit

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Invalid
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: ORM
  • Security Level: All
  • Labels:

Description

When i try to generate a new PersistentCollection like this:
###############################################
$collection = new ArrayCollection();
new \Doctrine\ORM\PersistentCollection(
$this->getEntityManager(),
new ClassMetadata(''),
$collection
);
###############################################
i get an typ hinting error like
"Expected array, got "Doctrine\Common\Collections\ArrayCollection"

This could be fixed by changing the type hinting for the Doctrine\ORM\PersistentCollection::__constructor
_From:_
###############################################
/**

  • Creates a new persistent collection.
    *
  • @param EntityManager $em The EntityManager the collection will be associated with.
  • @param ClassMetadata $class The class descriptor of the entity type of this collection.
  • @param array $coll The collection elements.
    */
    public function __construct(EntityManager $em, $class, $coll)
    {

                                                                                              1. _To:_
                                                                                                ###############################################
                                                                                                /**

  • Creates a new persistent collection.
    *
  • @param EntityManager $em The EntityManager the collection will be associated with.
  • @param ClassMetadata $class The class descriptor of the entity type of this collection.
  • @param \ArrayAccess $coll The collection elements.
    */
    public function __construct(EntityManager $em, $class, $coll)
    {
    ###############################################

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Torsten Granek added a comment -

When i try to generate a new PersistentCollection like this: 


     $collection = new ArrayCollection();
     new \Doctrine\ORM\PersistentCollection(
				$this->getEntityManager(),
				new ClassMetadata(''),
				 $collection
			);

I get an typ hinting error like
"Expected array, got "Doctrine\Common\Collections\ArrayCollection"

This could be fixed by changing the type hinting for the Doctrine\ORM\PersistentCollection::__constructor
_From:_

     /**
     * Creates a new persistent collection.
     *
     * @param EntityManager $em    The EntityManager the collection will be associated with.
     * @param ClassMetadata $class The class descriptor of the entity type of this collection.
     * @param array       $coll  The collection elements.
     */
    public function __construct(EntityManager $em, $class, $coll)
    {

_To:_

     /**
     * Creates a new persistent collection.
     *
     * @param EntityManager $em    The EntityManager the collection will be associated with.
     * @param ClassMetadata $class The class descriptor of the entity type of this collection.
     * @param \ArrayAccess $coll  The collection elements.
     */
    public function __construct(EntityManager $em, $class, $coll)
    {
Show
Torsten Granek added a comment - When i try to generate a new PersistentCollection like this: $collection = new ArrayCollection(); new \Doctrine\ORM\PersistentCollection( $ this ->getEntityManager(), new ClassMetadata(''), $collection ); I get an typ hinting error like "Expected array, got "Doctrine\Common\Collections\ArrayCollection" This could be fixed by changing the type hinting for the Doctrine\ORM\PersistentCollection::__constructor _ From: _ /** * Creates a new persistent collection. * * @param EntityManager $em The EntityManager the collection will be associated with. * @param ClassMetadata $class The class descriptor of the entity type of this collection. * @param array $coll The collection elements. */ public function __construct(EntityManager $em, $class, $coll) { _ To: _ /** * Creates a new persistent collection. * * @param EntityManager $em The EntityManager the collection will be associated with. * @param ClassMetadata $class The class descriptor of the entity type of this collection. * @param \ArrayAccess $coll The collection elements. */ public function __construct(EntityManager $em, $class, $coll) {
Hide
Permalink
Christophe Coevoet added a comment -

There is no typehint in the PersistentCollection constructor. So the issue cannot come from this place (the phpdoc is wrong btw, it expects a Collection, not an array)

Please give the full error, i.e. the message and the location so that we can know where it happens.

Show
Christophe Coevoet added a comment - There is no typehint in the PersistentCollection constructor. So the issue cannot come from this place (the phpdoc is wrong btw, it expects a Collection, not an array) Please give the full error, i.e. the message and the location so that we can know where it happens.
Hide
Permalink
Torsten Granek added a comment -

There error is not in the function declaration, it is in the @param in the doc block of the constructor.

Using PHPStorm as IDE i got this error thrown by the IDE it self, not php. (Screenshot will be attached)

Using ZF2 the error is on line 121 at:
vendor/doctrine/orm/lib/Doctrine/ORM/PersistentCollection.php

Show
Torsten Granek added a comment - There error is not in the function declaration, it is in the @param in the doc block of the constructor. Using PHPStorm as IDE i got this error thrown by the IDE it self, not php. (Screenshot will be attached) Using ZF2 the error is on line 121 at: vendor/doctrine/orm/lib/Doctrine/ORM/PersistentCollection.php
Hide
Permalink
Torsten Granek added a comment -

Using PHPStorm as IDE i got "Expected array, got "Doctrine\Common\Collections\ArrayCollection" thrown by the IDE it self, not php.

Show
Torsten Granek added a comment - Using PHPStorm as IDE i got "Expected array, got "Doctrine\Common\Collections\ArrayCollection" thrown by the IDE it self, not php.
Torsten Granek made changes -
Field Original Value New Value
Attachment screenshot-1.jpg [ 11380 ]
Torsten Granek made changes -
Attachment screenshot-1.jpg [ 11380 ]
Hide
Permalink
Torsten Granek added a comment -

Using PHPStorm as IDE i got "Expected array, got "Doctrine\Common\Collections\ArrayCollection" thrown by the IDE it self, not php.

Show
Torsten Granek added a comment - Using PHPStorm as IDE i got "Expected array, got "Doctrine\Common\Collections\ArrayCollection" thrown by the IDE it self, not php.
Torsten Granek made changes -
Attachment screenshot-1.jpg [ 11381 ]
Hide
Permalink
Marco Pivetta added a comment -

The correct type hint here is `Doctrine\Common\Collections\Collection`.

I'm closing this as invalid, since you shouldn't instantiate a persistent collection on your own. Consider opening a pull request at https://github.com/doctrine/doctrine2 instead if you want to fix the typehint.

Show
Marco Pivetta added a comment - The correct type hint here is `Doctrine\Common\Collections\Collection`. I'm closing this as invalid, since you shouldn't instantiate a persistent collection on your own. Consider opening a pull request at https://github.com/doctrine/doctrine2 instead if you want to fix the typehint.
Marco Pivetta made changes -
Status Open [ 1 ] Closed [ 6 ]
Assignee Benjamin Eberlei [ beberlei ] Marco Pivetta [ ocramius ]
Resolution Invalid [ 6 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-2303, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Marco Pivetta
    Reporter:
    Torsten Granek
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: