Doctrine 2 - ORM

EntityManager can't be extended easily

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Invalid
  • Affects Version/s: 2.3.1
  • Fix Version/s: None
  • Component/s: ORM
  • Labels:
    None

Description

public static function create($conn, Configuration $config, EventManager $eventManager = null)
{
    // ...
    return new EntityManager($conn, $config, $conn->getEventManager());
}

The EntityManager::create method uses new on the EntityManager class instead of static.

This makes extending that class not practical because we have to rewrite (duplicate) EntityManager::create.

Code could be extendable with:

public static function create($conn, Configuration $config, EventManager $eventManager = null)
{
    // ...
    return new static($conn, $config, $conn->getEventManager());
}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matthieu Napoli added a comment -

Pull request is here: https://github.com/doctrine/doctrine2/pull/535

Show
Matthieu Napoli added a comment - Pull request is here: https://github.com/doctrine/doctrine2/pull/535
Hide
Permalink
Benjamin Eberlei added a comment -

Its not desired to override the EntityManager, we are currently building a PR to build a decorator for the EntityManager instead. You can decorate the EntityManager yourself.

Show
Benjamin Eberlei added a comment - Its not desired to override the EntityManager, we are currently building a PR to build a decorator for the EntityManager instead. You can decorate the EntityManager yourself.
Hide
Permalink
Matthieu Napoli added a comment -

Benjamin Eberlei Shouldn't it be final then?

Show
Matthieu Napoli added a comment - Benjamin Eberlei Shouldn't it be final then?

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Matthieu Napoli
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: