Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-2166

Improve Identifier hashing in IdentiyMap

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      There are currently some drawbacks with identifier hashing:

      • They only work on one level for derived keys
      • The code is suspect to high performance requirements
      • Composite Keys might be suspect to weird bugs if they contain spaces.

      There is a PR by goetas (https://github.com/doctrine/doctrine2/pull/232) that solves some issues, however adds a performance hit.

      We should move the conditional logic of this code out and use a strategy pattern to improve both performance and robustness of this code.

        Activity

        Benjamin Eberlei created issue -

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: