Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-2139

Table collate/charset doesn't inherits from database

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: ORM, Tools
    • Security Level: All
    • Environment:
      Symfony2

      Description

      Using symfony2 command doctrine:schema:create the tables and Varchar fields are Collate/Charset are not inherited from database. I changed MySQL defaults to latin1/latin1_general_ci; The doctrine:database:create works; but tables and fields don't. So I found there is a code on MySqlPlataform.php:

      if ( ! isset($options['charset']))

      { $options['charset'] = 'utf8'; }

      if ( ! isset($options['collate']))

      { $options['collate'] = 'utf8_unicode_ci'; }

      $query .= 'DEFAULT CHARACTER SET ' . $options['charset'];
      $query .= ' COLLATE ' . $options['collate'];

      So if you don't pass collate and charset as entity options, it will put utf8 and utf8_unicode_ci instead of dabatase default charset.

      My suggestion is to change a little bit to:

      if (isset($options['charset']))

      { $query .= 'DEFAULT CHARACTER SET ' . $options['charset']; }

      if (isset($options['collate']))

      { $query .= ' COLLATE ' . $options['collate']; }

        Activity

        Hide
        Benjamin Eberlei added a comment -

        If we change it, then it will be like before and users disliked that very much. The decision is to use UTF-8 as default and everybody else has to change the information instead of the other way around.

        Show
        Benjamin Eberlei added a comment - If we change it, then it will be like before and users disliked that very much. The decision is to use UTF-8 as default and everybody else has to change the information instead of the other way around.

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            William Knak
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: