Uploaded image for project: 'Doctrine 2 - ORM'
  1. Doctrine 2 - ORM
  2. DDC-2123

[GH-502] Fix for invalid 'double-ON' SQL generation with entity inheritance type JOINED.


    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.1
    • Component/s: None
    • Security Level: All
    • Labels:


      This issue is created automatically through a Github pull request on behalf of gwis:

      Url: https://github.com/doctrine/doctrine2/pull/502


      In SqlWalker::walkJoin(), SqlWalker::walkRangeVariableDeclaration() can be
      called which may produce an 'ON' clause if the entity inheritance type is
      JOINED. As walkJoin() may then produce another ON clause, this results in
      invalid SQL (e.g. '... ON foo = bar ON (baz = quux) ...' when the inheritance
      type is JOINED.

      This adds a test and a fix for the problem, by checking for an inheritance type
      of JOINED in walkJoin() and using AND instead of ON in the appropriate place.

      It seems like this part of the code is begging to be refactored. This is my
      first foray into Doctrine internals and can't see a way to do this without
      stomping all over the rest of the code, but this section seems ripe for cleanup
      by somebody who is familiar.


        beberlei Benjamin Eberlei created issue -
        fabio.bat.silva Fabio B. Silva made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        beberlei Benjamin Eberlei made changes -
        Fix Version/s 2.3.1 [ 10323 ]


          • Assignee:
            beberlei Benjamin Eberlei
            beberlei Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            3 Start watching this issue


            • Created: