Problem with inheritance type: INHERITANCE_TYPE_NONE and INHERITANCE_TYPE_TABLE_PER_CLASS

Details

Type: Bug
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: 2.1
Fix Version/s: None
Component/s: DQL, Tools
Labels:
- dql
- schematool

Description

I tried to create inheritance entities with save policy table per class.
Simple fileds was created normally, but a field with ManyToOne type was lost.

I had found a solution.

In Doctrine\ORM\Tools\SchemaTool
...

private function _gatherRelationsSql($class, $table, $schema)
    {
        foreach ($class->associationMappings as $fieldName => $mapping) {

           // if (isset($mapping['inherited'])) { // - old version

	/**
             * SSW
             * It's the solution
             */
	if (isset($mapping['inherited']) && !$class->isInheritanceTypeNone() && !$class->isInheritanceTypeTablePerClass() ) {
                continue;
            }            

            $foreignClass = $this->_em->getClassMetadata($mapping['targetEntity']);
...

But it was enough. In DQL query a simple query was made wrong.

I had found a solution again.
In Doctrine\ORM\Query\SqlWalker
...

public function walkSelectExpression($selectExpression)
...

                // original => if (isset($mapping['inherited'])){
                // It's the solution
                if (isset($mapping['inherited']) && !$class->isInheritanceTypeNone() && !$class->isInheritanceTypeTablePerClass()) {
                    $tableName = $this->_em->getClassMetadata($mapping['inherited'])->table['name'];
                } else {
                    $tableName = $class->table['name'];
                }
...

This problems are topical for inheritance type: INHERITANCE_TYPE_NONE and INHERITANCE_TYPE_TABLE_PER_CLASS.

I don't know, may be my solutions are wrong. But some programmers want to correctly work with INHERITANCE_TYPE_TABLE_PER_CLASS.

Sorry for my english.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

dump.sql

07/Nov/12 12:06 AM

5 kB

SergSW
SSWTestBundle.rar

06/Nov/12 11:55 PM

5 kB

SergSW

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Fabio B. Silva added a comment - 05/Nov/12 10:17 PM

Hi SergSW

Could you try to write a failing test case ?

Thanks

Show

Fabio B. Silva added a comment - 05/Nov/12 10:17 PM Hi SergSW Could you try to write a failing test case ? Thanks

SergSW made changes - 06/Nov/12 10:48 PM

Field	Original Value	New Value
Attachment		Attach.php [ 11342 ]
Attachment		AttachTree.php [ 11343 ]

SergSW made changes - 06/Nov/12 11:53 PM

Attachment

Attach.php [ 11342 ]

SergSW made changes - 06/Nov/12 11:53 PM

Comment

[ Entities ]

SergSW made changes - 06/Nov/12 11:54 PM

Comment

[ I'm sorry, but I haven't time for write a test case.
I try to write a test case as will the time.
I attached Entity with the problem.
In database I lost a 'user' field in the 'AttachTree' table. ]

Hide

Permalink

SergSW added a comment - 06/Nov/12 11:55 PM

SSW/TestBundle with the problem

Show

SergSW added a comment - 06/Nov/12 11:55 PM SSW/TestBundle with the problem

SergSW made changes - 06/Nov/12 11:55 PM

Attachment

SSWTestBundle.rar [ 11344 ]

SergSW made changes - 06/Nov/12 11:56 PM

Attachment

AttachTree.php [ 11343 ]

Hide

Permalink

SergSW added a comment - 07/Nov/12 12:06 AM

I install the Symfony v2.0.18. and made small TestBundle.
I made schema database, by CLI "console doctrine:schema:update --force"
Result: Database schema updated successfully!
But I saw that I lost a field 'user_id' in a table 'AttachTree' (see Attach)

Show

SergSW added a comment - 07/Nov/12 12:06 AM I install the Symfony v2.0.18. and made small TestBundle. I made schema database, by CLI "console doctrine:schema:update --force" Result: Database schema updated successfully! But I saw that I lost a field 'user_id' in a table 'AttachTree' (see Attach)

Hide

Permalink

SergSW added a comment - 07/Nov/12 12:06 AM

MySQL dump

Show

SergSW added a comment - 07/Nov/12 12:06 AM MySQL dump

SergSW made changes - 07/Nov/12 12:06 AM

Attachment

dump.sql [ 11345 ]

Hide

Permalink

Benjamin Eberlei added a comment - 12/Nov/12 2:33 PM

Adjusted example formatting, don't apologize for your English, thanks for the report!

Show

Benjamin Eberlei added a comment - 12/Nov/12 2:33 PM Adjusted example formatting, don't apologize for your English, thanks for the report!

Benjamin Eberlei made changes - 12/Nov/12 2:33 PM

Description

I tried to create inheritance entities with save policy table per class.
Simple fileds was created normally, but a field with ManyToOne type was lost.

I had found a solution.

In Doctrine\ORM\Tools\SchemaTool
...
private function _gatherRelationsSql($class, $table, $schema)
    {
        foreach ($class->associationMappings as $fieldName => $mapping) {

           // if (isset($mapping['inherited'])) { // - old version

/**
             * SSW
             * It's the solution
             */
if (isset($mapping['inherited']) && !$class->isInheritanceTypeNone() && !$class->isInheritanceTypeTablePerClass() ) {
                continue;
            }

            $foreignClass = $this->_em->getClassMetadata($mapping['targetEntity']);
...

But it was enough. In DQL query a simple query was made wrong.

I had found a solution again.
In Doctrine\ORM\Query\SqlWalker
...
public function walkSelectExpression($selectExpression)
...

                // original => if (isset($mapping['inherited'])){
                // It's the solution
                if (isset($mapping['inherited']) && !$class->isInheritanceTypeNone() && !$class->isInheritanceTypeTablePerClass()) {
                    $tableName = $this->_em->getClassMetadata($mapping['inherited'])->table['name'];
                } else {
                    $tableName = $class->table['name'];
                }
...

This problems are topical for inheritance type: INHERITANCE_TYPE_NONE and INHERITANCE_TYPE_TABLE_PER_CLASS.

I don't know, may be my solutions are wrong. But some programmers want to correctly work with INHERITANCE_TYPE_TABLE_PER_CLASS.

Sorry for my english.

I tried to create inheritance entities with save policy table per class.
Simple fileds was created normally, but a field with ManyToOne type was lost.

I had found a solution.

In Doctrine\ORM\Tools\SchemaTool
...
{code}
private function _gatherRelationsSql($class, $table, $schema)
    {
        foreach ($class->associationMappings as $fieldName => $mapping) {

           // if (isset($mapping['inherited'])) { // - old version

/**
             * SSW
             * It's the solution
             */
if (isset($mapping['inherited']) && !$class->isInheritanceTypeNone() && !$class->isInheritanceTypeTablePerClass() ) {
                continue;
            }

            $foreignClass = $this->_em->getClassMetadata($mapping['targetEntity']);
...
{code}

But it was enough. In DQL query a simple query was made wrong.

I had found a solution again.
In Doctrine\ORM\Query\SqlWalker
...
{code}
public function walkSelectExpression($selectExpression)
...

                // original => if (isset($mapping['inherited'])){
                // It's the solution
                if (isset($mapping['inherited']) && !$class->isInheritanceTypeNone() && !$class->isInheritanceTypeTablePerClass()) {
                    $tableName = $this->_em->getClassMetadata($mapping['inherited'])->table['name'];
                } else {
                    $tableName = $class->table['name'];
                }
...
{code}

This problems are topical for inheritance type: INHERITANCE_TYPE_NONE and INHERITANCE_TYPE_TABLE_PER_CLASS.

I don't know, may be my solutions are wrong. But some programmers want to correctly work with INHERITANCE_TYPE_TABLE_PER_CLASS.

Sorry for my english.

Benjamin Eberlei made changes - 24/Dec/12 9:07 AM

Status

Open [ 1 ]

Awaiting Feedback [ 10000 ]

Hide

Permalink

Benjamin Eberlei added a comment - 24/Dec/12 9:08 AM

What version of 2.1 are you using? We don't actually support 2.1 anymore. Inheritance has always worked as used in hundrets of unit-tests, this changes look quite major a bug to have been missed before. I can't really explain whats happening here.

Show

Benjamin Eberlei added a comment - 24/Dec/12 9:08 AM What version of 2.1 are you using? We don't actually support 2.1 anymore. Inheritance has always worked as used in hundrets of unit-tests, this changes look quite major a bug to have been missed before. I can't really explain whats happening here.

Hide

Permalink

Marco Pivetta added a comment - 23/Jan/13 9:36 PM

SergSW news?

Show

Marco Pivetta added a comment - 23/Jan/13 9:36 PM SergSW news?

Anonymous made changes - 08/Apr/13 8:24 PM

Status

Awaiting Feedback [ 10000 ]

In Progress [ 3 ]

Benjamin Eberlei made changes - 08/Apr/13 8:43 PM

Status

In Progress [ 3 ]

Open [ 1 ]

This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-2119, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

Assignee:

Benjamin Eberlei

Reporter:

SergSW

Vote (0)

Watch (4)

Dates

Created:

03/Nov/12 6:57 PM

Updated:

08/Apr/13 8:43 PM