Details
-
Type:
Bug
-
Status:
Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.3.1
-
Component/s: None
-
Security Level: All
-
Labels:None
Description
This issue is created automatically through a Github pull request on behalf of lanthaler:
Url: https://github.com/doctrine/doctrine2/pull/498
Message:
Currently, the DocBlock annotations for member variables contain the variable name as description which is redundant and should be removed. Furthermore the class is annotated with the FQN instead of just the name. This makes automatically generated documentation quite ugly.
These changes will result in entities that as follows
```
/**
- User
* - @ORM\Table()
- @ORM\Entity
*/
class User
{
/** - @var string
* - @ORM\Column(name="name", type="string", length=255)
*/
private $name;
```
instead of this:
```
/**
- Some\Completely\Random\Namespace\User <--- FQN is not needed here
* - @ORM\Table()
- @ORM\Entity
*/
class User
{
/** - @var string $name <--- description is better left blank instead of using variable name
* - @ORM\Column(name="name", type="string", length=255)
*/
private $name;
```
Activity
Fabio B. Silva
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Benjamin Eberlei
made changes -
| Fix Version/s | 2.3.1 [ 10323 ] |
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
- Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-2116, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)
Just noticed that the message the doctrinebot posts on GitHub contains a typo: "thank you for **positing** this Pull Request". Don't know where to report this so I do it directly here