Doctrine 2 - ORM

[GH-481] check for false as a return value from get_parent_class(), not null

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.3.1
  • Component/s: None
  • Security Level: All
  • Labels:
    None

Description

This issue is created automatically through a Github pull request on behalf of beejeebus:

Url: https://github.com/doctrine/doctrine2/pull/481

Message:

MappingException::identifierRequired() and MappingException::classIsNotAValidEntityOrMappedSuperClass() both check for null, when they should check for false from get_parent_class().

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Eberlei added a comment -

A related Github Pull-Request [GH-481] was closed
https://github.com/doctrine/doctrine2/pull/481

Show
Benjamin Eberlei added a comment - A related Github Pull-Request [GH-481] was closed https://github.com/doctrine/doctrine2/pull/481
Hide
Permalink
Fabio B. Silva added a comment -

Merged : https://github.com/doctrine/doctrine2/commit/9d0b254407e6f8827e0f00aa4ed0fcefc6111aad

Show
Fabio B. Silva added a comment - Merged : https://github.com/doctrine/doctrine2/commit/9d0b254407e6f8827e0f00aa4ed0fcefc6111aad

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Benjamin Eberlei
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: