Doctrine 2 - ORM

indexBy breaks cascade remove

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Can't Fix
  • Affects Version/s: 2.3
  • Fix Version/s: None
  • Component/s: ORM
  • Labels:
    None
  • Environment:
    Ubuntu 12.04, PHP 5.3, 64 Bit, Symfony 2

Description

Adding the annotation indexBy causes the cascade annotation to be ignored:

/**
*

  • @var ArrayCollection
  • @ORM\OneToMany(targetEntity="LocationData", mappedBy="location", indexBy="name", cascade= {"persist", "remove"}

    )
    */
    protected $data;

Will cause an error when deleting the objects:

An exception occurred while executing 'DELETE FROM location WHERE id = ?' with params

{"1":19306}

:

SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`symfony`.`location_data`, CONSTRAINT `FK_2DF7462364D218E` FOREIGN KEY (`location_id`) REFERENCES `location` (`id`))

Removing indexBy fixes the issue.

My class structure is:

Location has many LocationData
LocationData extends AbstractData

The name field I am trying to index by comes from the AbstractData class.

  1. File
    AbstractData.php
    28/Sep/12 10:15 AM
    1 kB
    James Bench
  2. File
    DDC2036Test.php
    29/Sep/12 7:15 PM
    4 kB
    Fabio B. Silva
  3. File
    Location.php
    28/Sep/12 10:15 AM
    1 kB
    James Bench
  4. File
    LocationData.php
    28/Sep/12 10:15 AM
    0.5 kB
    James Bench
  5. Text File
    msql.log
    02/Oct/12 12:39 PM
    2 kB
    Fabio B. Silva
  6. Text File
    sql_flush.log
    02/Oct/12 10:22 AM
    6 kB
    James Bench

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Fabio B. Silva added a comment -

Hi James

Do you have a failing test case ?
Could you attach/paste your entity please ?

Thanks

Show
Fabio B. Silva added a comment - Hi James Do you have a failing test case ? Could you attach/paste your entity please ? Thanks
Hide
Permalink
James Bench added a comment -

Entity exhibiting the behavior.

Show
James Bench added a comment - Entity exhibiting the behavior.
Hide
Permalink
Fabio B. Silva added a comment -

Hi James,
I can't reproduce,

Are you sure that you dont have more than one LocationData whith the same name ?

When working with indexBy the index columns must be unique into the collection.
I recommend that you add a unique constrain in the columns name.

If i'm wrong about it, please
Could you change the added test case and try to make it fails ?

Thanks

Show
Fabio B. Silva added a comment - Hi James, I can't reproduce, Are you sure that you dont have more than one LocationData whith the same name ? When working with indexBy the index columns must be unique into the collection. I recommend that you add a unique constrain in the columns name. If i'm wrong about it, please Could you change the added test case and try to make it fails ? Thanks
Hide
Permalink
James Bench added a comment -

Hi Fabio,

The test case uses a SQLite DB without any foreign keys so the issue wouldn't be apparent.

How would I run the test against a MySQL db?

I've also attached the SQL log for the script I'm running, it looks the same as the output from the testcase.

Cheers,JB

Show
James Bench added a comment - Hi Fabio, The test case uses a SQLite DB without any foreign keys so the issue wouldn't be apparent. How would I run the test against a MySQL db? I've also attached the SQL log for the script I'm running, it looks the same as the output from the testcase. Cheers,JB
Hide
Permalink
James Bench added a comment -

SQL Log from script causing errors.

Show
James Bench added a comment - SQL Log from script causing errors.
Hide
Permalink
Fabio B. Silva added a comment -

Hi James,

You must copy phpunit.xml.dist to phpunit.xml and change the database configurations.

I have attached the mysql log, the test case works fine.

Show
Fabio B. Silva added a comment - Hi James, You must copy phpunit.xml.dist to phpunit.xml and change the database configurations. I have attached the mysql log, the test case works fine.
Hide
Permalink
James Bench added a comment -

It appears that it only attempts to delete 68 LocationData rows but in the database there are 76.

Show
James Bench added a comment - It appears that it only attempts to delete 68 LocationData rows but in the database there are 76.
Hide
Permalink
James Bench added a comment -

Okay, I've found the reason for this; the name isn't unique, some are duplicated.
Once the duplicates are removed there are 68 rows.
I'll add a unique index to the name column and hopefully this problem will go away.

Not sure whether you would consider this a bug.

Thanks for your help.

Show
James Bench added a comment - Okay, I've found the reason for this; the name isn't unique, some are duplicated. Once the duplicates are removed there are 68 rows. I'll add a unique index to the name column and hopefully this problem will go away. Not sure whether you would consider this a bug. Thanks for your help.
Hide
Permalink
Fabio B. Silva added a comment -

No problem, you are welcome

Actually isn't a bug, it is a documented behavior.

"Fields that are used for the index by feature HAVE to be unique in the database."

http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/working-with-indexed-associations.html#working-with-indexed-assocations

Show
Fabio B. Silva added a comment - No problem, you are welcome Actually isn't a bug, it is a documented behavior. "Fields that are used for the index by feature HAVE to be unique in the database." http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/working-with-indexed-associations.html#working-with-indexed-assocations
Hide
Permalink
Fabio B. Silva added a comment -

Fields that are used for the index by feature HAVE to be unique in the database.

http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/working-with-indexed-associations.html#working-with-indexed-assocations

Show
Fabio B. Silva added a comment - Fields that are used for the index by feature HAVE to be unique in the database. http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/working-with-indexed-associations.html#working-with-indexed-assocations

People

  • Assignee:
    Fabio B. Silva
    Reporter:
    James Bench
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: