Bug in UnitOfWork and ManyToMany relations

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 2.1
Fix Version/s: 2.1.8, 2.3
Component/s: ORM
Security Level: All
Labels:
None
Environment:
symfony2

Description

Lets say, I have entity Forum with ManyToMany relations with User.
I need to validate user changes and I use code like

$uow = $this->getDoctrine()~~>getEntityManager()~~>getUnitOfWork();
$uow->computeChangeSets();
$changeSet = $uow->getEntityChangeSet($forum);
if (.... bla-bla-bla....)

{ $em = $this->getDoctrine()->getEntityManager(); $em->persist($forum); $em->flush(); }

Unfortunately, whenever I try to change manyToMany relations - I got error
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '4-4' for key 'PRIMARY'

If I comment uow code - everything works just great.

It looks like bug in UnitOfWork implementation.

Let me know if you need more details from me.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Marco Pivetta added a comment - 16/Jul/12 1:04 AM

What is the part you commented out? Also, in what context is your code executed?

Show

Marco Pivetta added a comment - 16/Jul/12 1:04 AM What is the part you commented out? Also, in what context is your code executed?

Hide

Permalink

Andrew added a comment - 16/Jul/12 9:15 AM

I got error when $em->persist($forum); $em->flush(); executed.

I can create github repository with code, which reproduce this error, if you want.

Show

Andrew added a comment - 16/Jul/12 9:15 AM I got error when $em->persist($forum); $em->flush(); executed. I can create github repository with code, which reproduce this error, if you want.

Hide

Permalink

Marco Pivetta added a comment - 16/Jul/12 9:19 AM

Please do

Show

Marco Pivetta added a comment - 16/Jul/12 9:19 AM Please do

Hide

Permalink

Andrew added a comment - 16/Jul/12 9:27 AM

that would be simple symfony2 application - will it work for you?

Show

Andrew added a comment - 16/Jul/12 9:27 AM that would be simple symfony2 application - will it work for you?

Hide

Permalink

Marco Pivetta added a comment - 16/Jul/12 9:28 AM

As long as the code is related to doctrine. Otherwise this issue is quite incomplete

Show

Marco Pivetta added a comment - 16/Jul/12 9:28 AM As long as the code is related to doctrine. Otherwise this issue is quite incomplete

Hide

Permalink

Andrew added a comment - 16/Jul/12 5:30 PM

Done, please check https://github.com/zhil/testDoctrine

In few words, when I add code like
$uow = $this->getDoctrine()~~>getEntityManager()~~>getUnitOfWork();
$uow->computeChangeSets();
$changeSet = $uow->getEntityChangeSet($product);

before $em->persist(); $em->flush();

I got fake MYSQL error

Thank in advance for your help

Show

Andrew added a comment - 16/Jul/12 5:30 PM Done, please check https://github.com/zhil/testDoctrine In few words, when I add code like $uow = $this->getDoctrine() >getEntityManager() >getUnitOfWork(); $uow->computeChangeSets(); $changeSet = $uow->getEntityChangeSet($product); before $em->persist(); $em->flush(); I got fake MYSQL error Thank in advance for your help

Hide

Permalink

Andrew added a comment - 19/Jul/12 6:36 PM

Just wonder - is it bug in doctrine2 or its problems somewhere else? (symfony2/my code/ etc.)

This is part of the live project - I need to fix it

Show

Andrew added a comment - 19/Jul/12 6:36 PM Just wonder - is it bug in doctrine2 or its problems somewhere else? (symfony2/my code/ etc.) This is part of the live project - I need to fix it

Hide

Permalink

Marco Pivetta added a comment - 19/Jul/12 6:45 PM

I think it is related with the fact that you're using the `UnitOfWork` manually. You can probably try to fix the problem by moving your code to an event subscriber until this is fixed.

Show

Marco Pivetta added a comment - 19/Jul/12 6:45 PM I think it is related with the fact that you're using the `UnitOfWork` manually. You can probably try to fix the problem by moving your code to an event subscriber until this is fixed.

Hide

Permalink

Andrew added a comment - 19/Jul/12 7:15 PM

Well, I used UnitOfWork, because I need to know what was changed during object validation (for example, property status can be changed only in predefined cases etc.).

Ok, thanks for the suggestion - I will implement some temporary solution for this problem

Show

Andrew added a comment - 19/Jul/12 7:15 PM Well, I used UnitOfWork, because I need to know what was changed during object validation (for example, property status can be changed only in predefined cases etc.). Ok, thanks for the suggestion - I will implement some temporary solution for this problem

Hide

Permalink

Marco Pivetta added a comment - 19/Jul/12 7:17 PM

I think I spotted where this happens, but I don't have a clear overview on the situation. Will try to work on this...

Show

Marco Pivetta added a comment - 19/Jul/12 7:17 PM I think I spotted where this happens, but I don't have a clear overview on the situation. Will try to work on this...

Hide

Permalink

Andrew added a comment - 19/Jul/12 7:36 PM

Thanks for the checking this issue.
I have already patched my application with ugly patch. Just in case solution will take some time and somebody else will need similar patch. I patched entity like

entity {
public $previousStatusBugfix = -1;
public function setStatus($status)

{ // check http://www.doctrine-project.org/jira/browse/DDC-1925?focusedCommentId=18344#comment-18344 // Ticket #651 $this->previousStatusBugfix = $this->status; $this->status = $status; }

}

and validator

if(($object->previousStatusBugfix != ~~1) && ($object~~>previousStatusBugfix != $object->getStatus()))

{ $changeSet = array("status"=>array(0=>$object->previousStatusBugfix, 1=>$object->getStatus())); }

Show

Andrew added a comment - 19/Jul/12 7:36 PM Thanks for the checking this issue. I have already patched my application with ugly patch. Just in case solution will take some time and somebody else will need similar patch. I patched entity like entity { public $previousStatusBugfix = -1; public function setStatus($status) { // check http://www.doctrine-project.org/jira/browse/DDC-1925?focusedCommentId=18344#comment-18344 // Ticket #651 $this->previousStatusBugfix = $this->status; $this->status = $status; } } and validator if(($object->previousStatusBugfix != 1) && ($object >previousStatusBugfix != $object->getStatus())) { $changeSet = array("status"=>array(0=>$object->previousStatusBugfix, 1=>$object->getStatus())); }

Hide

Permalink

Marco Pivetta added a comment - 19/Jul/12 9:43 PM

I just wrote a couple of tests (attaching them to the issue shortly) and found out that on `>=2.2.x` your code runs perfectly.
The problem is on the `2.1.x` branch, and the commit that fixed the issue is https://github.com/doctrine/doctrine2/commit/4474d30 for ~~DDC-1210~~

Now looking if it can be merged into `2.1.x` since it doesn't seem to cause any BC break.

Show

Marco Pivetta added a comment - 19/Jul/12 9:43 PM I just wrote a couple of tests (attaching them to the issue shortly) and found out that on `>=2.2.x` your code runs perfectly. The problem is on the `2.1.x` branch, and the commit that fixed the issue is https://github.com/doctrine/doctrine2/commit/4474d30 for DDC-1210 Now looking if it can be merged into `2.1.x` since it doesn't seem to cause any BC break.

Hide

Permalink

Benjamin Eberlei added a comment - 19/Jul/12 10:03 PM

A related Github Pull-Request [GH-402] was opened
https://github.com/doctrine/doctrine2/pull/402

Show

Benjamin Eberlei added a comment - 19/Jul/12 10:03 PM A related Github Pull-Request [GH-402] was opened https://github.com/doctrine/doctrine2/pull/402

Hide

Permalink

Benjamin Eberlei added a comment - 19/Jul/12 10:07 PM

A related Github Pull-Request [GH-403] was opened
https://github.com/doctrine/doctrine2/pull/403

Show

Benjamin Eberlei added a comment - 19/Jul/12 10:07 PM A related Github Pull-Request [GH-403] was opened https://github.com/doctrine/doctrine2/pull/403

Hide

Permalink

Marco Pivetta added a comment - 19/Jul/12 10:16 PM

Duplicate of ~~DDC-1210~~

Show

Marco Pivetta added a comment - 19/Jul/12 10:16 PM Duplicate of DDC-1210

Hide

Permalink

Benjamin Eberlei added a comment - 23/Jul/12 5:02 AM

A related Github Pull-Request [GH-403] was closed
https://github.com/doctrine/doctrine2/pull/403

Show

Benjamin Eberlei added a comment - 23/Jul/12 5:02 AM A related Github Pull-Request [GH-403] was closed https://github.com/doctrine/doctrine2/pull/403

Hide

Permalink

Benjamin Eberlei added a comment - 29/Jul/12 10:09 AM

A related Github Pull-Request [GH-402] was closed
https://github.com/doctrine/doctrine2/pull/402

Show

Benjamin Eberlei added a comment - 29/Jul/12 10:09 AM A related Github Pull-Request [GH-402] was closed https://github.com/doctrine/doctrine2/pull/402

People

Assignee:

Marco Pivetta

Reporter:

Andrew

Vote (0)

Watch (3)

Dates

Created:

14/Jul/12 4:44 AM

Updated:

29/Jul/12 10:12 AM

Resolved:

29/Jul/12 10:12 AM