Case sensitive columnName's don't work anymore

Oh!

I'll fix it asap, that means this evening. Sorry

Can you try again? I implemented case handling in Schema now and added a test-case for this problem.

Fixed.

The strtolower in Table is just for the platform independent access to column names, however for generation the Column::getName() is used. There is never a strtolower applied to this, so i am a bit puzzled to where this should happen.

I have to look at it again.

@Nico: Just to shed some light on this issue because I assume this sounds trivial to you at first glance. The casing is a major pain with database portability. For example, whether you query for "coLuMn" or "colUmn" or "COLUMN", Postgres will always give you lowercase in the result set. And Oracle will give you all uppercase.

PDO tried to address this with the PDO::ATTR_CASE constant that you can set LOWER or UPPER to force a unified casing in result sets.
But since we're not solely relying on PDO, we cant use that. For example, the PDO_OCI driver sucks badly and so we have a custom driver around the OCI8 extension.

Now these casing differences cause Benjamin trouble as he tries to determine differences between database schemas and things like that.

So while we would be happy with preserving the names everywhere, the databases play against us as they dont all return the names "as is".

And now we're trying hard to make this invisible for the user.

Of course you should be able to use mixed case column names and let doctrine worry about the rest.

Just wanted to give some background info.

Ok, I understand. This sounds quite difficult... thanks for the background info, this always helps me to understand some of the Doctrine internals...

As you said, for portability reasons it is not a good idea to rely on the users' knowledge about the database (i.e. to always use columnName's with the 'right' case), because in some cases columnNames are automatically generated... And with DBMs being configurable it may also be a bad idea to rely on Doctrine mapping casing behavior to DB drivers...

Yet in my project there is the simple requirement to keep the existing database model and use DDC on top of it, i.e. especially not renaming columns or changing primary keys, etc.

@Benjamin: Can you review my latest changeset?

Also, I discovered this:

$theJoinTable->createColumn( 
    $columnName, $class->getTypeOfColumn($joinColumn['referencedColumnName']), array('notnull' => false)
);

Doesnt that mean all foreign keys are nullable? shouldnt this be:

$theJoinTable->createColumn( 
    $columnName, $class->getTypeOfColumn($joinColumn['referencedColumnName']), array('notnull' => ! $joinColumn['nullable'])
);

?

Can this be considered fixed now?

Looks good!

How can I get PostgreSQL case sensitive quoted columns works?

My table structure is like this:

CREATE TABLE "Author"
(
"IdAuthor" serial NOT NULL,
"Name" character varying(100) NOT NULL DEFAULT ''::character varying,
"CreationDate" timestamp without time zone,
"ModificationDate" timestamp without time zone,
CONSTRAINT "Author_pkey" PRIMARY KEY ("IdAuthor")
)
WITH (
OIDS=FALSE
);

And in php...

<?php
// $em instanceof EntityManager
$q = $em->createQuery('select a from MyDomain\Model\Author a where a."IdAuthor" = 1');
$author = $q->getResult();

and this returns the exception:

[Syntax Error] line 0, col 56: Error: Expected =, <, <=, <>, >, >=, !=, got 'IdAuthor'

Sorry if it's a wrong place to do de question; and many thanks for your help.
Best regards.