Doctrine 2 - ORM

[GH-392] Replaced a shallow-copy with a deep-copy to avoid side effects.

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.3
  • Component/s: None
  • Security Level: All
  • Labels:
    None

Description

This issue is created automatically through a Github pull request on behalf of egeloen:

Url: https://github.com/doctrine/doctrine2/pull/392

Message:

Hey!

I'm currently using Symfony 2.1 + Doctrine master branch + Pager fanta master branch.

I'm facing a very vicious issue.

The doctrine paginator is able to clone a query with his `cloneQuery` method. This method will only clone the query without this parameters & hints. The issue is the parameters is setted with the `setParameters` method which will only affect the ArrayCollection reference to the new query builder and so, shared the reference between the two queries.

This PR will make a deep-copy of the ArrayCollection instead of a simple shallow-copy.

I'm not sure if this fix is the best solution.

Let me know if you need more information.

Activity

Ascending order - Click to sort in descending order
Benjamin Eberlei made changes -
Field Original Value New Value
Workflow jira [ 13826 ] jira-feedback [ 14092 ]
Benjamin Eberlei made changes -
Workflow jira-feedback [ 14092 ] jira-feedback2 [ 15956 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 15956 ] jira-feedback3 [ 18202 ]
Hide
Permalink
Benjamin Eberlei added a comment -

A related Github Pull-Request [GH-392] was closed
https://github.com/doctrine/doctrine2/pull/392

Show
Benjamin Eberlei added a comment - A related Github Pull-Request [GH-392] was closed https://github.com/doctrine/doctrine2/pull/392
Benjamin Eberlei made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 2.3 [ 10185 ]
Resolution Fixed [ 1 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-1911, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Benjamin Eberlei
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: