Uploaded image for project: 'Doctrine 2 - ORM'
  1. Doctrine 2 - ORM
  2. DDC-1893

Doctrine\ORM\Mapping\Driver\AnnotationDriver::create() not updated for new annotation readers

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Mapping Drivers
    • Security Level: All
    • Labels:
      None

      Description

      After refactoring of annotation readers, there are new defaults and the current implementation calls undefined method, because Doctrine\Common\Annotations\AnnotationReader has been refactored too. The new way should be probably requiring Doctrine\Common\Annotations\Reader interface as $reader parameter and if not present constructing the default as in Doctrine\ORM\Configuration::create :

      AnnotationRegistry::registerFile(_DIR_ . '/Mapping/Driver/DoctrineAnnotations.php');

      $reader = new \Doctrine\Common\Annotations\SimpleAnnotationReader();
      $reader->addNamespace('Doctrine\ORM\Mapping');
      $reader = new \Doctrine\Common\Annotations\CachedReader($reader, new ArrayCache());

        Activity

        vasekpurchart Vašek Purchart created issue -
        Hide
        ocramius Marco Pivetta added a comment -

        Looking into this today

        Show
        ocramius Marco Pivetta added a comment - Looking into this today
        Hide
        beberlei Benjamin Eberlei added a comment -

        $config->newDefaultAnnotationDriver should have a flag for picking the simple or the "ORM
        " prefixed reader

        Show
        beberlei Benjamin Eberlei added a comment - $config->newDefaultAnnotationDriver should have a flag for picking the simple or the "ORM " prefixed reader
        beberlei Benjamin Eberlei made changes -
        Field Original Value New Value
        Workflow jira [ 13801 ] jira-feedback [ 14086 ]
        beberlei Benjamin Eberlei made changes -
        Workflow jira-feedback [ 14086 ] jira-feedback2 [ 15950 ]
        beberlei Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 15950 ] jira-feedback3 [ 18197 ]
        Show
        ocramius Marco Pivetta added a comment - Handled in DDC-1915 ( https://github.com/doctrine/doctrine2/pull/396 )
        beberlei Benjamin Eberlei made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.3 [ 10185 ]
        Resolution Fixed [ 1 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={expand=changesets[0:20].revisions[0:29],reviews, query=DDC-1893}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            beberlei Benjamin Eberlei
            Reporter:
            vasekpurchart Vašek Purchart
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: