Problem with column quoting on Delete

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 2.1.6
Fix Version/s: 2.3
Component/s: ORM
Security Level: All
Labels:
None

Description

delete($entity) from BasicEntityPersiter is not considering that the columns might be quoted.

public function delete($entity) {
	$identifier = $this->_em->getUnitOfWork()->getEntityIdentifier($entity);
        $this->deleteJoinTableRecords($identifier);

        $id = array_combine($this->_class->getIdentifierColumnNames(), $identifier);
        $this->_conn->delete($this->_class->getQuotedTableName($this->_platform), $id);
}

The third line:

        $id = array_combine($this->_class->getIdentifierColumnNames(), $identifier);
        // might be fixed in this way (as example):
        foreach ($identifier as $columnName => $value) {
                $id[$this->_class->getQuotedColumnName($columnName, $this->_platform)] = $value;
        }

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Role.php

25/Jun/12 11:26 PM

2 kB

Ignacio Larranaga
User.php

25/Jun/12 11:26 PM

4 kB

Ignacio Larranaga

Activity

Ascending order - Click to sort in descending order

Fabio B. Silva made changes - 20/Jun/12 8:07 PM

Field	Original Value	New Value
Description	delete($entity) from BasicEntityPersiter is not considering that the columns might be quoted. public function delete($entity) { $identifier = $this->_em->getUnitOfWork()->getEntityIdentifier($entity); $this->deleteJoinTableRecords($identifier); $id = array_combine($this->_class->getIdentifierColumnNames(), $identifier); $this->_conn->delete($this->_class->getQuotedTableName($this->_platform), $id); } The third line: $id = array_combine($this->_class->getIdentifierColumnNames(), $identifier); might be fixed in this way (as example): foreach ($identifier as $columnName => $value) { $id[$this->_class->getQuotedColumnName($columnName, $this->_platform)] = $value; }	delete($entity) from BasicEntityPersiter is not considering that the columns might be quoted. {code} public function delete($entity) { $identifier = $this->_em->getUnitOfWork()->getEntityIdentifier($entity); $this->deleteJoinTableRecords($identifier); $id = array_combine($this->_class->getIdentifierColumnNames(), $identifier); $this->_conn->delete($this->_class->getQuotedTableName($this->_platform), $id); } {code} The third line: {code} $id = array_combine($this->_class->getIdentifierColumnNames(), $identifier); // might be fixed in this way (as example): foreach ($identifier as $columnName => $value) { $id[$this->_class->getQuotedColumnName($columnName, $this->_platform)] = $value; } {code}