Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-1846

Pessimistic lock does not retreive latest version of entity when entity is already in doctrine cache

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Git Master
    • Fix Version/s: 2.2.3
    • Component/s: ORM
    • Security Level: All
    • Labels:
      None
    • Environment:
      Mysql 5.5.22-0ubuntu1

      Description

      When setting a pessimistic lock on an entity (e.g. a row lock) and retreiving an entity from the database, Doctrine returns the entity from cache if it has any. When updating a counter on an entity for example, it is important the row is locked, retreived, updated and then unlocked to guarantee the counter keeps in sync. Using $em->clear(); before $em->find(); is a work-around for this problem, but as requested by Benjamin Eberlei on the google groups thread (https://groups.google.com/forum/?fromgroups#!topic/doctrine-user/N8Xop2-XbTY) this bugreport is made to fix this without the need of clear().

      In the next example, if the entity is previously retreived already, find() returns that version instead of retreiving the current version from the database after the rowlock is set. When $em->clear(); can be used to work-around the problem

      // $em instanceof EntityManager
      
      //$em->clear(); // Uncommenting this fixed the problem
      $em->getConnection()->beginTransaction();
      
      try {
      	$entity = $em->find('Entity', $id, LockMode::PESSIMISTIC_WRITE);
      	
      	/* Update some fields, for example, decrease a counter */
      	$entity->setCounter($entity->getCounter() - 1);
      	
      	$em->persist($entity);
      	$em->flush();
      	$em->getConnection()->commit();
      } catch ( \Exception $ex ) {
      	$em->getConnection()->rollback();
      }
      

        Issue Links

          Activity

          Bram Klein Gunnewiek created issue -
          Benjamin Eberlei made changes -
          Field Original Value New Value
          Workflow jira [ 13740 ] jira-feedback [ 14071 ]
          Benjamin Eberlei made changes -
          Workflow jira-feedback [ 14071 ] jira-feedback2 [ 15935 ]
          Benjamin Eberlei made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 2.2.3 [ 10196 ]
          Resolution Fixed [ 1 ]
          Benjamin Eberlei made changes -
          Workflow jira-feedback2 [ 15935 ] jira-feedback3 [ 19483 ]
          Marco Pivetta made changes -
          Link This issue relates to DDC-2929 [ DDC-2929 ]

            People

            • Assignee:
              Benjamin Eberlei
              Reporter:
              Bram Klein Gunnewiek
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: