Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-1812

Modify ResultSetMapping#addMetaResult function definition

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.2, 2.2.1, 2.2.2, Git Master
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      Give correct names to arguments

          public function addMetaResult($alias, $columnName, $fieldName, $isIdentifierColumn = false)
          {
      

      $alias - should be $tableAlias
      $columnName should be $columnAlias
      $fieldName should be $columnName

      Here are some exmple calls from code:
      AbstractEntityInheritancePersister.php
      79: $this->_rsm->addMetaResult('r', $columnAlias, $joinColumnName);
      SqlWalker.php
      $this->_rsm->addMetaResult($dqlAlias, $columnAlias, $discrColumn['fieldName']);
      $this->_rsm->addMetaResult($dqlAlias, $columnAlias, $srcColumn, (isset($assoc['id']) && $assoc['id'] === true));
      $this->_rsm->addMetaResult($dqlAlias, $columnAlias, $srcColumn);

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            ross neacoders
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: