DQL exception when building query with multiple from and join parts

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: Git Master
Fix Version/s: 2.3
Component/s: ORM
Security Level: All
Labels:
None

Description

Query builder creates bad DQL if multiple FROM and JOIN parts are used.

As example such query builder code

$qb->from('A', 'a')
  ->from('B', 'b')
  ->join('b.c', 'c')
  ->join('c.d', 'd');

will generate DQL

...
  FROM A a 
    INNER JOIN c.d d, 
  B b 
    INNER JOIN b.c c
...

but should generate this instead

...
  FROM A a,
  B b 
    INNER JOIN b.c c 
    INNER JOIN c.d d
...

The DQL parser raises exception

Doctrine\ORM\Query\QueryException: [Semantical Error] line 0, col 61 near '.d d, B': Error: Identification Variable c used in join path expression but was not defined before.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

DDC1757Test.php

03/Apr/12 12:58 PM

2 kB

Aigars Gedroics
patch-1757.patch

03/Apr/12 1:14 PM

2 kB

Aigars Gedroics

Activity

Ascending order - Click to sort in descending order

Aigars Gedroics made changes - 03/Apr/12 12:54 PM

Field	Original Value	New Value
Description	Query builder creates bad DQL if multiple FROM and JOIN parts are used. As example such query builder code {code} $qb->from('A', 'a') ->from('B', 'b') ->join('b.c', 'c') ->join('c.d', 'd'); {code} will generate DQL {code} ... FROM A a INNER JOIN c.d d, B b INNER JOIN b.c c ... {code} but should generate this instead {code} ... FROM A a, B b INNER JOIN b.c c INNER JOIN c.d d ... {code} The DQL parser raises exception {code} Doctrine\ORM\Query\QueryException: [Semantical Error] line 0, col 61 near '.d d, Supra\Tests\Doctrine\DDC2000B': Error: Identification Variable c used in join path expression but was not defined before. {code}	Query builder creates bad DQL if multiple FROM and JOIN parts are used. As example such query builder code {code} $qb->from('A', 'a') ->from('B', 'b') ->join('b.c', 'c') ->join('c.d', 'd'); {code} will generate DQL {code} ... FROM A a INNER JOIN c.d d, B b INNER JOIN b.c c ... {code} but should generate this instead {code} ... FROM A a, B b INNER JOIN b.c c INNER JOIN c.d d ... {code} The DQL parser raises exception {code} Doctrine\ORM\Query\QueryException: [Semantical Error] line 0, col 61 near '.d d, B': Error: Identification Variable c used in join path expression but was not defined before. {code}