Doctrine 2 - ORM

LIKE clausule should accept functions on the pattern

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.1.6
  • Fix Version/s: None
  • Component/s: ORM
  • Security Level: All
  • Labels:
    None

Description

Example:
SELECT .... WHERE upper(n.title) LIKE upper(:filter)

should be a valid SQL, now is rejected because the walker only accept a variable or an string expression.

I'm adding a patch to address this.

  1. Text File
    Parser.patch
    21/Mar/12 7:30 PM
    0.8 kB
    Ignacio Larranaga
  2. Text File
    SqlWalker.patch
    21/Mar/12 5:40 PM
    0.9 kB
    Ignacio Larranaga

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ignacio Larranaga added a comment -

Sorry the Parser has to be modified also to allow expressions to be recognized, I'm attaching the necessary patch.

Show
Ignacio Larranaga added a comment - Sorry the Parser has to be modified also to allow expressions to be recognized, I'm attaching the necessary patch.
Hide
Permalink
Benjamin Eberlei added a comment -

I am sure there is a reason why the walker doesn't accept this such as not all supported vendors allowing functions in right hand side LIKE expressions, but i am not sure about this.

Show
Benjamin Eberlei added a comment - I am sure there is a reason why the walker doesn't accept this such as not all supported vendors allowing functions in right hand side LIKE expressions, but i am not sure about this.
Hide
Permalink
Glen Ainscow added a comment -

This is not possible either:

WHERE CASE WHEN p.name IS NULL THEN u.username ELSE p.name END LIKE :name

Show
Glen Ainscow added a comment - This is not possible either: WHERE CASE WHEN p.name IS NULL THEN u.username ELSE p.name END LIKE :name
Hide
Permalink
Thomas Mayer added a comment -

In my case it worked when using "=" instead of "LIKE".

//works:
(CASE WHEN (Book.id = BookFrom.id) THEN BookTo.displayName ELSE BookFrom.displayName END) = :name

//[Syntax Error] line 0, col 1217: Error: Expected =, <, <=, <>, >, >=, !=, got 'LIKE'
(CASE WHEN (Book.id = BookFrom.id) THEN BookTo.displayName ELSE BookFrom.displayName END) LIKE :name

So the LIKE operator only needs to be allowed here.

I'm wondering which vendor should not be able to handle that:
The CASE WHEN ... THEN ... END is documented in DQL, and allowed.
LIKE itself is allowed.
If an RDBMs cannot use CASE WHEN and LIKE in combination, this would be a strange limitation.

Show
Thomas Mayer added a comment - In my case it worked when using "=" instead of "LIKE". //works: (CASE WHEN (Book.id = BookFrom.id) THEN BookTo.displayName ELSE BookFrom.displayName END) = :name // [Syntax Error] line 0, col 1217: Error: Expected =, <, <=, <>, >, >=, !=, got 'LIKE' (CASE WHEN (Book.id = BookFrom.id) THEN BookTo.displayName ELSE BookFrom.displayName END) LIKE :name So the LIKE operator only needs to be allowed here. I'm wondering which vendor should not be able to handle that: The CASE WHEN ... THEN ... END is documented in DQL, and allowed. LIKE itself is allowed. If an RDBMs cannot use CASE WHEN and LIKE in combination, this would be a strange limitation.

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Ignacio Larranaga
Vote (1)
Watch (2)

Dates

  • Created:
    Updated: