Doctrine 2 - ORM

Better unique constraints handling or even updateIfExists/findOneOrCreate

Details

  • Type: New Feature New Feature
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.2.1
  • Fix Version/s: None
  • Component/s: ORM
  • Security Level: All
  • Labels:
    None

Description

It is too hard handle rows duplication now. As adviced here http://stackoverflow.com/questions/3967226/checking-for-duplicate-keys-with-doctrine-2 we should catch \PDOException with code 23000. This is bad behavior.

So I propose:
a. Add DuplicateRowException wich will throwed by flush method (maybe wrapped PDOException) with method "getDuplicatedProperties" (based on sql error description parsing + mapping)
b. Add method findOneOrCreate (hello, Propel!) or updateIfExists to ObjectInterface, EntityManager
c. Combine a, b

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mark van der Velden added a comment -

I don't think it should be limited to the flush method, however, as this can occur with "custom" queries also. It would be ideal if the errors being generated can be much more easily (read: standardized) caught or read.

I'm in favor of letting the database handle integrity checks, and not run a query to decide wether or not the update or insert queries will violate. Hence the desire to handle this more gracefully.

Show
Mark van der Velden added a comment - I don't think it should be limited to the flush method, however, as this can occur with "custom" queries also. It would be ideal if the errors being generated can be much more easily (read: standardized) caught or read. I'm in favor of letting the database handle integrity checks, and not run a query to decide wether or not the update or insert queries will violate. Hence the desire to handle this more gracefully.
Hide
Permalink
Lucas van Lierop added a comment -

The DBAL statement class (https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Statement.php) has and execute method which might be a good place to catch and convert the generic PDOExceptions by wrapping the line

$stmt = $this->stmt->execute($params);

in a try/catch statement which then calls some kind of PDOException to Doctrine Exception method

Show
Lucas van Lierop added a comment - The DBAL statement class ( https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Statement.php ) has and execute method which might be a good place to catch and convert the generic PDOExceptions by wrapping the line $stmt = $this->stmt->execute($params); in a try/catch statement which then calls some kind of PDOException to Doctrine Exception method

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Konstantin
Vote (5)
Watch (2)

Dates

  • Created:
    Updated: