Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-1693

SqlWalker doesn't handle LockMode correctly

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2-BETA1, 2.2-BETA2, 2.2.0-RC1, 2.2, 2.2.1, Git Master
    • Fix Version/s: 2.2.2
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      Both issues are in SqlWalker::walkSelectStatement().
      First is a typo on line 443 in master where LockMode::PESSIMISTIC_OPTIMISTIC is used instead of LockMode::OPTIMISTIC. This results in a fatal undefined class constant error.
      Additionally, LockMode::NONE is not handled and results in an exception. An empty case will solve that issue.

        Activity

        Billy Bednar created issue -
        Billy Bednar made changes -
        Field Original Value New Value
        Summary SqlWalker uses non-existant LockMode SqlWalker doesn't handle LockMode correctly
        Description In SqlWalker::walkSelectStatement(), LockMode::PESSIMISTIC_OPTIMISTIC is used instead of LockMode::OPTIMISTIC, which results in a fatal undefined class constant error. Line 443 in master. Both issues are in SqlWalker::walkSelectStatement().
        First is a typo on line 443 in master where LockMode::PESSIMISTIC_OPTIMISTIC is used instead of LockMode::OPTIMISTIC. This results in a fatal undefined class constant error.
        Additionally, LockMode::NONE is not handled and results in an exception. An empty case will solve that issue.
        Hide
        Benjamin Eberlei added a comment -

        Fixed, merged back into 2.2 branch.

        Show
        Benjamin Eberlei added a comment - Fixed, merged back into 2.2 branch.
        Benjamin Eberlei made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.2.2 [ 10195 ]
        Resolution Fixed [ 1 ]
        Benjamin Eberlei made changes -
        Workflow jira [ 13517 ] jira-feedback [ 15267 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback [ 15267 ] jira-feedback2 [ 17131 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 17131 ] jira-feedback3 [ 19384 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-1693, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Billy Bednar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: