Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-1690

Notify policy listeners are not attached to entities with Notify policy

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.3.2
    • Component/s: ORM
    • Security Level: All
    • Labels:
      None

      Description

      It seems that it happens because the UnitOfWork::addToIdentityMap() is not the only way to add an entity to the identity map. It is possible to do it directly by assigning array values (pulling my hair why?) . But the code in that method also adds a property changed listener to an entity. As a result that entity is not persisted properly as it does not have a listener. I spent a lot of time trying to figure out why some of my entities were persisted and others no. That happens for entities of same class with parent - children associations.

      Probably the notify policy is not very popular otherwise the bug would have been reported long time ago.

      Adding these lines to the UnitOfWork at line 2004 fixes the issue:

          // PERF: Inlined & optimized code from UnitOfWork#registerManaged()
          $newValueOid = spl_object_hash($newValue);
          $this->entityIdentifiers[$newValueOid] = $associatedId;
          $this->identityMap[$targetClass->rootEntityName][$relatedIdHash] = $newValue;
          // new lines
       -- if ($newValue instanceof NotifyPropertyChanged) {
       --     $newValue->addPropertyChangedListener($this);
       -- }
          //end of new lines
          $this->entityStates[$newValueOid] = self::STATE_MANAGED;
          // make sure that when an proxy is then finally loaded, $this->originalEntityData is set also!
      

        Activity

        Hide
        Guilherme Blanco added a comment -

        Changing the code (Perf & Inline block) to this:

        $this->registerManaged($newValue, $associatedId, array($field => $newValue));
        

        Also fixed the issue and the performance impact was around 3% during my tests.

        Show
        Guilherme Blanco added a comment - Changing the code (Perf & Inline block) to this: $ this ->registerManaged($newValue, $associatedId, array($field => $newValue)); Also fixed the issue and the performance impact was around 3% during my tests.
        Hide
        Oleg Namaka added a comment -

        So Doctrine 2.2.2 is out but the fix for this serious issue was not included in it. What version then it is supposed to fix? Doctrine seems to be riddled with issues related to the Notify strategy (look here for another related issue: http://www.doctrine-project.org/jira/browse/DDC-1775). It renders that strategy unusable.

        Show
        Oleg Namaka added a comment - So Doctrine 2.2.2 is out but the fix for this serious issue was not included in it. What version then it is supposed to fix? Doctrine seems to be riddled with issues related to the Notify strategy (look here for another related issue: http://www.doctrine-project.org/jira/browse/DDC-1775 ). It renders that strategy unusable.
        Hide
        Patrick Schwisow added a comment -

        Submitted a pull request for this fix: https://github.com/doctrine/doctrine2/pull/541

        Show
        Patrick Schwisow added a comment - Submitted a pull request for this fix: https://github.com/doctrine/doctrine2/pull/541

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Oleg Namaka
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: