Doctrine 2 - ORM

Annotation @version is not allowed to be declared on class

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2
  • Fix Version/s: 2.2.1
  • Component/s: Mapping Drivers, ORM
  • Security Level: All
  • Labels:
    None

Description

I upgraded to Doctrine 2.2 and got following exception:

"Doctrine\Common\Annotations\AnnotationException [Semantical Error] Annotation @version is not allowed to be declared on class SomeEntityClass. You may only use this annotation on these code elements: PROPERTY."

In Doctrine 2.1 no such exception has been thrown. I use following annotation for all my classes in my projects:

@version $Id: SomeEntityClass.php 509 2012-02-03 09:38:48Z mf $

Thus I cannot upgrade to Doctrine 2.2 for now.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Eberlei added a comment -

Hm maybe the SimpleAnnotationReader should not validate targets? What do you say Fabio/Johannes?

Show
Benjamin Eberlei added a comment - Hm maybe the SimpleAnnotationReader should not validate targets? What do you say Fabio/Johannes?
Hide
Permalink
Benjamin Eberlei added a comment -

Its definately a BC break.

Show
Benjamin Eberlei added a comment - Its definately a BC break.
Benjamin Eberlei made changes -
Field Original Value New Value
Assignee Benjamin Eberlei [ beberlei ] Fabio B. Silva [ fabio.bat.silva ]
Fabio B. Silva made changes -
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Fabio B. Silva added a comment -

Hi Benjamin

This parser identifies the phpdoc annotation @version as the doctrine annotation @Doctrine\ORM\Mapping\Version

SimpleReader does not recognize entity imports. If consider the namespaces (SimpleAnnotationReader#addNamespace), this annotation exists within the namespace "Doctrine\ORM\Mapping\"

This could be fixed considering just CamelCaseClasses, so @version is not equal @Version

Benjamin and Johannes, please take a look at this commit :
https://github.com/FabioBatSilva/common/commit/842bf5883c405e89d211e5ccfff1d8d64e05a486

Show
Fabio B. Silva added a comment - Hi Benjamin This parser identifies the phpdoc annotation @version as the doctrine annotation @Doctrine\ORM\Mapping\Version SimpleReader does not recognize entity imports. If consider the namespaces (SimpleAnnotationReader#addNamespace), this annotation exists within the namespace "Doctrine\ORM\Mapping\" This could be fixed considering just CamelCaseClasses, so @version is not equal @Version Benjamin and Johannes, please take a look at this commit : https://github.com/FabioBatSilva/common/commit/842bf5883c405e89d211e5ccfff1d8d64e05a486
Hide
Permalink
Benjamin Eberlei added a comment -

This breaks BC, so we cant do this.

Show
Benjamin Eberlei added a comment - This breaks BC, so we cant do this.
Hide
Permalink
Benjamin Eberlei added a comment -

Merged PR into master and 2.2

Show
Benjamin Eberlei added a comment - Merged PR into master and 2.2
Benjamin Eberlei made changes -
Status In Progress [ 3 ] Resolved [ 5 ]
Fix Version/s 2.2.1 [ 10194 ]
Resolution Fixed [ 1 ]
Benjamin Eberlei made changes -
Workflow jira [ 13463 ] jira-feedback [ 15238 ]
Benjamin Eberlei made changes -
Workflow jira-feedback [ 15238 ] jira-feedback2 [ 17102 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 17102 ] jira-feedback3 [ 19355 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-1660, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Fabio B. Silva
    Reporter:
    Miroslav Fedeles
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: