Primary Keys as Foreign Keys - still not working in Reverse Engineering in 2.1.6

Benjamin Eberlei added a comment - 12/Feb/12 9:39 AM In lib/Doctrine/ORM/Mapping/DatabaseDriver.php

ross neacoders added a comment - 12/Feb/12 2:43 PM Thank you Benjamin, Actually started tracking this error from /lib/Doctrine/ORM/Mapping/ClasMetadataInfo.php and step-bystep it goes to /lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php Actually it calls ClasMetadataInfo::mapMayToOne instead of mapOneToOne in such situations. Will investigate further. Pff... DatabaseDriver.php looks a hard class.

ross neacoders added a comment - 12/Feb/12 8:02 PM - edited I am almost done with it - need a little more help from you: So I fixed the DatabaseDriver so it correctly calls mapOneToOne and passes association_mapping to it. /** * Adds a one-to-one mapping. * * @param array $mapping The mapping. */ public function mapOneToOne(array $mapping) { $mapping['type'] = self::ONE_TO_ONE; $mapping = $ this ->_validateAndCompleteOneToOneMapping($mapping); $ this ->_storeAssociationMapping($mapping); print_r($assocMapping); <--added this to see what structure we have on output } this gives the following structure Array ( [fieldName] => someguid <--- my primary key field, which is also foreign key [targetEntity] => Additionalinfo <--- target table [id] => 1 <--- indicates that this mapping is also id (primary key) [joinColumns] => Array ( [0] => Array ( [name] => Someguid <--- join columns [referencedColumnName] => UniqueID ) ) [type] => 1 <-- indicates ONE-TO-ONE assoc mapping [mappedBy] => [inversedBy] => [isOwningSide] => 1 [sourceEntity] => Sampledata [fetch] => 2 ..... (i omit other data as not important) ) Now the problem: in my entity I got the following /** * @ var Additionalinfo * * @ORM\OneToOne(targetEntity= "Additionalinfo" ) * @ORM\JoinColumns({ * @ORM\JoinColumn(name= "Someguid" , referencedColumnName= "UniqueID" ) * }) */ private $someguid; So it correctly created a One-To-One mapping, but it did not preserve @Id attribute. I guess this is because field_associations and mapping_associations are processed in separate way, and in mapping_association it ignores the $mapping ["id"] setting. Do you know what code is managing creating the <id ....> / @Id staff - it is common for annotation/yaml/xml, e.x. when i generated xml for entity, it also does not contain <id > tag.

ross neacoders added a comment - 12/Feb/12 9:47 PM Update: fixed the last problem in Doctrine/ORM/Tools/EntityGenerator.php Still has to be fixed in YAML/XML exporters - not very familiar with the syntax.

Benjamin Eberlei added a comment - 03/Mar/12 9:00 PM This PR fixes the problem https://github.com/doctrine/doctrine2/pull/280

Benjamin Eberlei added a comment - 14/Mar/12 8:40 PM Fixed