Get PersistentCollection::getDeleteDiff is empty when collection changes from 1 item to zero items

Details

Type: Bug
Status: Awaiting Feedback
Priority: Minor
Resolution: Unresolved
Affects Version/s: None
Fix Version/s: None
Component/s: ORM
Security Level: All
Labels:
None
Environment:
Symfony2

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

DDC1630Test.php

20/Feb/12 10:33 AM

1 kB

Benjamin Eberlei

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Steve Müller added a comment - 09/Feb/12 12:23 AM - edited

Same problem here. I wanted to write some unit tests, checking the entity relations and ran into exactly the same problem. Maybe my code can provide some more information (Group entity is the owning side, role entity is the inverse side):

WHAT DOES NOT WORK:

        /**
         * Test ArrayCollection
         */
        $group = new Group('Group Test');
        $em->persist($group);
        $em->flush();

        $groups = new ArrayCollection();
        $groups->add($group);

        $this->role->setGroups($groups);

        $this->assertEquals($groups, $this->role->getGroups());

        /**
         * Test PersistentCollection
         */
        $em->persist($this->role);
        $em->flush();

        $groups = $this->role->getGroups();
        $groups->removeElement($group); // first remove element before adding a new one

        $group = new Group('Group Test 2');
        $em->persist($group);
        $em->flush();
        $groups->add($group);        

        $this->role->setGroups($groups);

        $this->assertEquals($groups, $this->role->getGroups());

WHAT WORKS:

        /**
         * Test ArrayCollection
         */
        $group = new Group('Group Test');
        $em->persist($group);
        $em->flush();

        $groups = new ArrayCollection();
        $groups->add($group);

        $this->role->setGroups($groups);

        $this->assertEquals($groups, $this->role->getGroups());

        /**
         * Test PersistentCollection
         */
        $em->persist($this->role);
        $em->flush();

        $groups = $this->role->getGroups();

        $group2 = new Group('Group Test 2');
        $em->persist($group2);
        $em->flush();
        $groups->add($group2);  // first adding a new element before removing one

        $groups->removeElement($group);

        $this->role->setGroups($groups);

        $this->assertEquals($groups, $this->role->getGroups());

Hope this helps in any way... I tried figuring it out on my own but I am too drunk right now xD

Show

Steve Müller added a comment - 09/Feb/12 12:23 AM - edited Same problem here. I wanted to write some unit tests, checking the entity relations and ran into exactly the same problem. Maybe my code can provide some more information (Group entity is the owning side, role entity is the inverse side): WHAT DOES NOT WORK: /** * Test ArrayCollection */ $group = new Group('Group Test'); $em->persist($group); $em->flush(); $groups = new ArrayCollection(); $groups->add($group); $ this ->role->setGroups($groups); $ this ->assertEquals($groups, $ this ->role->getGroups()); /** * Test PersistentCollection */ $em->persist($ this ->role); $em->flush(); $groups = $ this ->role->getGroups(); $groups->removeElement($group); // first remove element before adding a new one $group = new Group('Group Test 2'); $em->persist($group); $em->flush(); $groups->add($group); $ this ->role->setGroups($groups); $ this ->assertEquals($groups, $ this ->role->getGroups()); WHAT WORKS: /** * Test ArrayCollection */ $group = new Group('Group Test'); $em->persist($group); $em->flush(); $groups = new ArrayCollection(); $groups->add($group); $ this ->role->setGroups($groups); $ this ->assertEquals($groups, $ this ->role->getGroups()); /** * Test PersistentCollection */ $em->persist($ this ->role); $em->flush(); $groups = $ this ->role->getGroups(); $group2 = new Group('Group Test 2'); $em->persist($group2); $em->flush(); $groups->add($group2); // first adding a new element before removing one $groups->removeElement($group); $ this ->role->setGroups($groups); $ this ->assertEquals($groups, $ this ->role->getGroups()); Hope this helps in any way... I tried figuring it out on my own but I am too drunk right now xD

Hide

Permalink

Benjamin Eberlei added a comment - 10/Feb/12 8:41 PM

Thanks for the report, formatted it

Show

Benjamin Eberlei added a comment - 10/Feb/12 8:41 PM Thanks for the report, formatted it

Hide

Permalink

Benjamin Eberlei added a comment - 10/Feb/12 8:42 PM

Which version is that btw?

Show

Benjamin Eberlei added a comment - 10/Feb/12 8:42 PM Which version is that btw?

Hide

Permalink

Steve Müller added a comment - 16/Feb/12 9:52 PM

Occurs in version 2.1.6

Show

Steve Müller added a comment - 16/Feb/12 9:52 PM Occurs in version 2.1.6

Hide

Permalink

Benjamin Eberlei added a comment - 20/Feb/12 10:00 AM

If group is the owning side, why do you only set Role::$groups? This has to be the other way around or not?

Show

Benjamin Eberlei added a comment - 20/Feb/12 10:00 AM If group is the owning side, why do you only set Role::$groups? This has to be the other way around or not?

Hide

Permalink

Benjamin Eberlei added a comment - 20/Feb/12 10:33 AM

@Steve

I cannot reproduce your issue.

Attached is a test script.

Your code is very weird btw, why are you getting and setting groups collection? It is passed by reference so you can just have something like $role->addGroup() and $role->removeGroup() and encapsulate the logic?

Also your tests are pretty useless, you check if two variables which are the same reference to the same collection are the same. Which should always be true.

@Lee

Can you provide more details? I cant verify this without more details.

Show

Benjamin Eberlei added a comment - 20/Feb/12 10:33 AM @Steve I cannot reproduce your issue. Attached is a test script. Your code is very weird btw, why are you getting and setting groups collection? It is passed by reference so you can just have something like $role->addGroup() and $role->removeGroup() and encapsulate the logic? Also your tests are pretty useless, you check if two variables which are the same reference to the same collection are the same. Which should always be true. @Lee Can you provide more details? I cant verify this without more details.

Benjamin Eberlei made changes - 20/Feb/12 10:33 AM

Field	Original Value	New Value
Priority	Major [ 3 ]	Minor [ 4 ]

Benjamin Eberlei made changes - 20/Feb/12 10:33 AM

Attachment

DDC1630Test.php [ 11164 ]

Benjamin Eberlei made changes - 07/Jul/12 2:01 PM

Workflow

jira [ 13405 ]

jira-feedback [ 14019 ]

Benjamin Eberlei made changes - 07/Jul/12 2:08 PM

Workflow

jira-feedback [ 14019 ]

jira-feedback2 [ 15883 ]

Benjamin Eberlei made changes - 08/Jul/12 6:21 AM

Workflow

jira-feedback2 [ 15883 ]

jira-feedback3 [ 18139 ]

Benjamin Eberlei made changes - 08/Jul/12 6:37 AM

Status

Open [ 1 ]

Awaiting Feedback [ 10000 ]

Anonymous made changes - 08/Sep/12 6:14 PM

Status

Awaiting Feedback [ 10000 ]

In Progress [ 3 ]

Alexander made changes - 09/Feb/13 9:52 PM

Status

In Progress [ 3 ]

Awaiting Feedback [ 10000 ]

Hide

Permalink

Alexander added a comment - 09/Feb/13 9:52 PM

Can anyone provide us with more feedback?

Show

Alexander added a comment - 09/Feb/13 9:52 PM Can anyone provide us with more feedback?

This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-1630, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

Assignee:

Benjamin Eberlei

Reporter:

Lee

Vote (2)

Watch (1)

Dates

Created:

31/Jan/12 6:38 PM

Updated:

09/Feb/13 9:52 PM