Doctrine 2 - ORM

Get PersistentCollection::getDeleteDiff is empty when collection changes from 1 item to zero items

Details

  • Type: Bug Bug
  • Status: Awaiting Feedback Awaiting Feedback
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: ORM
  • Security Level: All
  • Labels:
    None
  • Environment:
    Symfony2

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Steve Müller added a comment - - edited

Same problem here. I wanted to write some unit tests, checking the entity relations and ran into exactly the same problem. Maybe my code can provide some more information (Group entity is the owning side, role entity is the inverse side):

WHAT DOES NOT WORK:

        /**
         * Test ArrayCollection
         */
        $group = new Group('Group Test');
        $em->persist($group);
        $em->flush();

        $groups = new ArrayCollection();
        $groups->add($group);

        $this->role->setGroups($groups);

        $this->assertEquals($groups, $this->role->getGroups());

        /**
         * Test PersistentCollection
         */
        $em->persist($this->role);
        $em->flush();

        $groups = $this->role->getGroups();
        $groups->removeElement($group); // first remove element before adding a new one

        $group = new Group('Group Test 2');
        $em->persist($group);
        $em->flush();
        $groups->add($group);        

        $this->role->setGroups($groups);

        $this->assertEquals($groups, $this->role->getGroups());

WHAT WORKS:

        /**
         * Test ArrayCollection
         */
        $group = new Group('Group Test');
        $em->persist($group);
        $em->flush();

        $groups = new ArrayCollection();
        $groups->add($group);

        $this->role->setGroups($groups);

        $this->assertEquals($groups, $this->role->getGroups());

        /**
         * Test PersistentCollection
         */
        $em->persist($this->role);
        $em->flush();

        $groups = $this->role->getGroups();

        $group2 = new Group('Group Test 2');
        $em->persist($group2);
        $em->flush();
        $groups->add($group2);  // first adding a new element before removing one

        $groups->removeElement($group);

        $this->role->setGroups($groups);

        $this->assertEquals($groups, $this->role->getGroups());

Hope this helps in any way... I tried figuring it out on my own but I am too drunk right now xD

Show
Steve Müller added a comment - - edited Same problem here. I wanted to write some unit tests, checking the entity relations and ran into exactly the same problem. Maybe my code can provide some more information (Group entity is the owning side, role entity is the inverse side): WHAT DOES NOT WORK: /** * Test ArrayCollection */ $group = new Group('Group Test'); $em->persist($group); $em->flush(); $groups = new ArrayCollection(); $groups->add($group); $ this ->role->setGroups($groups); $ this ->assertEquals($groups, $ this ->role->getGroups()); /** * Test PersistentCollection */ $em->persist($ this ->role); $em->flush(); $groups = $ this ->role->getGroups(); $groups->removeElement($group); // first remove element before adding a new one $group = new Group('Group Test 2'); $em->persist($group); $em->flush(); $groups->add($group); $ this ->role->setGroups($groups); $ this ->assertEquals($groups, $ this ->role->getGroups()); WHAT WORKS: /** * Test ArrayCollection */ $group = new Group('Group Test'); $em->persist($group); $em->flush(); $groups = new ArrayCollection(); $groups->add($group); $ this ->role->setGroups($groups); $ this ->assertEquals($groups, $ this ->role->getGroups()); /** * Test PersistentCollection */ $em->persist($ this ->role); $em->flush(); $groups = $ this ->role->getGroups(); $group2 = new Group('Group Test 2'); $em->persist($group2); $em->flush(); $groups->add($group2); // first adding a new element before removing one $groups->removeElement($group); $ this ->role->setGroups($groups); $ this ->assertEquals($groups, $ this ->role->getGroups()); Hope this helps in any way... I tried figuring it out on my own but I am too drunk right now xD
Hide
Permalink
Benjamin Eberlei added a comment -

Thanks for the report, formatted it

Show
Benjamin Eberlei added a comment - Thanks for the report, formatted it
Hide
Permalink
Benjamin Eberlei added a comment -

Which version is that btw?

Show
Benjamin Eberlei added a comment - Which version is that btw?
Hide
Permalink
Steve Müller added a comment -

Occurs in version 2.1.6

Show
Steve Müller added a comment - Occurs in version 2.1.6
Hide
Permalink
Benjamin Eberlei added a comment -

If group is the owning side, why do you only set Role::$groups? This has to be the other way around or not?

Show
Benjamin Eberlei added a comment - If group is the owning side, why do you only set Role::$groups? This has to be the other way around or not?
Hide
Permalink
Benjamin Eberlei added a comment -

@Steve

I cannot reproduce your issue.

Attached is a test script.

Your code is very weird btw, why are you getting and setting groups collection? It is passed by reference so you can just have something like $role->addGroup() and $role->removeGroup() and encapsulate the logic?

Also your tests are pretty useless, you check if two variables which are the same reference to the same collection are the same. Which should always be true.

@Lee

Can you provide more details? I cant verify this without more details.

Show
Benjamin Eberlei added a comment - @Steve I cannot reproduce your issue. Attached is a test script. Your code is very weird btw, why are you getting and setting groups collection? It is passed by reference so you can just have something like $role->addGroup() and $role->removeGroup() and encapsulate the logic? Also your tests are pretty useless, you check if two variables which are the same reference to the same collection are the same. Which should always be true. @Lee Can you provide more details? I cant verify this without more details.
Hide
Permalink
Alexander added a comment -

Can anyone provide us with more feedback?

Show
Alexander added a comment - Can anyone provide us with more feedback?

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Lee
Vote (2)
Watch (1)

Dates

  • Created:
    Updated: