Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-1624

Locking CTI doesnt work on SQL Server

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.5
    • Component/s: ORM
    • Security Level: All
    • Labels:
      None

      Description

      The WITH Keyowrd is appended to the whole FROM .. JOIN .. block instead of behind the FROM block.

        Issue Links

          Activity

          Benjamin Eberlei created issue -
          Benjamin Eberlei made changes -
          Field Original Value New Value
          Fix Version/s 2.3 [ 10185 ]
          Fix Version/s 2.2 [ 10157 ]
          Benjamin Eberlei made changes -
          Workflow jira [ 13396 ] jira-feedback [ 14017 ]
          Benjamin Eberlei made changes -
          Workflow jira-feedback [ 14017 ] jira-feedback2 [ 15881 ]
          Benjamin Eberlei made changes -
          Workflow jira-feedback2 [ 15881 ] jira-feedback3 [ 18137 ]
          Benjamin Eberlei made changes -
          Fix Version/s 2.4 [ 10321 ]
          Fix Version/s 2.3 [ 10185 ]
          Benjamin Eberlei made changes -
          Fix Version/s 2.5 [ 10522 ]
          Fix Version/s 2.4 [ 10321 ]
          Benjamin Eberlei made changes -
          Link This issue is duplicated by DBAL-559 [ DBAL-559 ]
          Hide
          William Schaller added a comment -

          Is there a better workaround for this issue than this?

          diff --git a/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php b/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php
          index c9af278..2f192ea 100644
          --- a/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php
          +++ b/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php
          @@ -1020,7 +1020,7 @@ class SQLServerPlatform extends AbstractPlatform
                           $lockClause = '';
                   }
           
          -        return $fromClause . $lockClause;
          +        return $fromClause;// . $lockClause;
               }
           
               /**
          

          I've just been keeping my own fork of DBAL to work around this bug, but it would be nice if it was fixed. Bad thing is that I see no convenient or non-obfuscated way of doing it, so I don't feel comfortable submitting a patch.

          This is pretty severe, as it completely breaks select queries against entities with inheritance.

          Show
          William Schaller added a comment - Is there a better workaround for this issue than this? diff --git a/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php b/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php index c9af278..2f192ea 100644 --- a/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php +++ b/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php @@ -1020,7 +1020,7 @@ class SQLServerPlatform extends AbstractPlatform $lockClause = ''; } - return $fromClause . $lockClause; + return $fromClause;// . $lockClause; } /** I've just been keeping my own fork of DBAL to work around this bug, but it would be nice if it was fixed. Bad thing is that I see no convenient or non-obfuscated way of doing it, so I don't feel comfortable submitting a patch. This is pretty severe, as it completely breaks select queries against entities with inheritance.
          Hide
          William Schaller added a comment -

          I think this is fixed in 2.4...

          Show
          William Schaller added a comment - I think this is fixed in 2.4...
          Hide
          Marco Pivetta added a comment -

          Already solved in 2.4 indeed.

          Show
          Marco Pivetta added a comment - Already solved in 2.4 indeed.
          Marco Pivetta made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Benjamin Eberlei [ beberlei ] Marco Pivetta [ ocramius ]
          Resolution Fixed [ 1 ]

          This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

          • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-1624, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

            People

            • Assignee:
              Marco Pivetta
              Reporter:
              Benjamin Eberlei
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: