Resolution: Won't Fix
Affects Version/s: None
Fix Version/s: 2.2
Security Level: All
Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/213
I'm wondering myself if the QueryBuilder::getQuery is a good method name.
Actually, a getMethodObject makes me think that I can use many times the getMethodObject and work with the same object.
In my code, the problem is that getQuery return a new instance of Query each time that I call getQuery.
Furthermore, the getQuery method invoke a createQuery method.
So, maybe the QueryBuiler::getQuery can store a reference to the created Query instance, and if the QueryBuilder::getQuery is call many times without any change return the stored instance.
If the QueryBuilder::getQuery have to generate a new Query, throw an exception or something like that.
Because of a change to QueryBuilder::createQuery is a major change, I don't think that It could be the solution, but it's a reflexion around this.
What do you think about that ?
|Field||Original Value||New Value|
|Status||Open [ 1 ]||Resolved [ 5 ]|
|Assignee||Benjamin Eberlei [ beberlei ]||Guilherme Blanco [ guilhermeblanco ]|
|Fix Version/s||2.2-DEV [ 10157 ]|
|Resolution||Won't Fix [ 2 ]|
|Workflow||jira [ 13262 ]||jira-feedback [ 15147 ]|
|Workflow||jira-feedback [ 15147 ]||jira-feedback2 [ 17011 ]|
|Workflow||jira-feedback2 [ 17011 ]||jira-feedback3 [ 19264 ]|