Doctrine 2 - ORM

With/on extra join clauses are not yet processed properly by SqlWalker

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0-ALPHA3
  • Fix Version/s: 2.0-BETA1
  • Component/s: DQL, ORM
  • Security Level: All
  • Labels:
    None

Description

Reference thread: http://groups.google.com/group/doctrine-user/browse_thread/thread/5f3e01818cf30878

Criteria specified with QueryBuilder::leftJoin() do not appear in the native query. Looks like the with/on extra join clauses are not yet processed
properly by the SqlWalker that constructs the SQL+parameters.

Issue Links

is referenced by

Bug - A problem which impairs or prevents the functions of the product. DDC-176 Query::iterate is broken when using JOIN

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.
relates to

Improvement - An improvement or enhancement to an existing feature or task. DDC-177 Throw exception if ON/WITH join condition override/extension is used on a fetch-join with HYDRATE_OBJECT

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guilherme Blanco added a comment -

They talk about the same thing.

Show
Guilherme Blanco added a comment - They talk about the same thing.
Hide
Permalink
Benjamin Eberlei added a comment -

Patch that fixes both DDC-135 but restricts it by the assumptions of DDC-177, namely not allowing to fetch join a LEFT JOIN .. ON/WITH clause

Show
Benjamin Eberlei added a comment - Patch that fixes both DDC-135 but restricts it by the assumptions of DDC-177 , namely not allowing to fetch join a LEFT JOIN .. ON/WITH clause
Hide
Permalink
Roman S. Borschel added a comment -

@Benjamin: Thats a good start but its not yet what its supposed to be. WITH appends to the join condition whereas ON overrides it. In the patch I only see ON implemented and it behaves like WITH.

Show
Roman S. Borschel added a comment - @Benjamin: Thats a good start but its not yet what its supposed to be. WITH appends to the join condition whereas ON overrides it. In the patch I only see ON implemented and it behaves like WITH.
Hide
Permalink
Roman S. Borschel added a comment -

I see you implemented WITH also, but they are supposed to produce different SQL. ON overrides, WITH appends.

Show
Roman S. Borschel added a comment - I see you implemented WITH also, but they are supposed to produce different SQL. ON overrides, WITH appends.
Hide
Permalink
Roman S. Borschel added a comment -

@Benjamin: Btw. I think we should only implement WITH for now. ON is a bit too scary for me and I'd like to see more usecases first.

Show
Roman S. Borschel added a comment - @Benjamin: Btw. I think we should only implement WITH for now. ON is a bit too scary for me and I'd like to see more usecases first.
Hide
Permalink
Benjamin Eberlei added a comment -

Ah now i understand, i didn't get the difference

I will strip down the patch to WITH then and handle it appropriately

Show
Benjamin Eberlei added a comment - Ah now i understand, i didn't get the difference I will strip down the patch to WITH then and handle it appropriately
Hide
Permalink
Benjamin Eberlei added a comment -

The way i implemented ON it worked as WITH anyways.

Show
Benjamin Eberlei added a comment - The way i implemented ON it worked as WITH anyways.
Hide
Permalink
Benjamin Eberlei added a comment -

Fixed, WITH clauses are processed correctly now. ON clauses throw an exception.

Show
Benjamin Eberlei added a comment - Fixed, WITH clauses are processed correctly now. ON clauses throw an exception.

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Reinier Kip
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: