Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-1347

Github-PR-110 by shesek: Support NULL in EntityRepository's magic findBy and findOneBy methods

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of

      {username}

      :

      Url: https://github.com/doctrine/doctrine2/pull/110

      Message:

      The magic `findBy` and `findOneBy` methods don't support passing NULL as the value, because ["we cannot (yet) transform it into IS NULL"](https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/EntityRepository.php#L207).

      However, `BasicEntityPersister::_getSelectConditionSQL()` [does support that](https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Persisters/BasicEntityPersister.php#L1229). It seems like leftovers from when there was no support for it. I tried it locally (after applying this change) and it does seem to work well.

        Activity

        Benjamin Eberlei created issue -
        Benjamin Eberlei made changes -
        Field Original Value New Value
        Workflow jira [ 12968 ] jira-feedback [ 13962 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback [ 13962 ] jira-feedback2 [ 15826 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 15826 ] jira-feedback3 [ 18082 ]

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: