Doctrine 2 - ORM

Enable nesting of OR and AND statements in DQL queries

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.2
  • Component/s: DQL
  • Security Level: All
  • Labels:
    None

Description

Currently it is not allowed to nest AND and OR conditions in themselves. However, this comes in handy if you try to do a dynamic query rewriting, where you want to add some more conditions without knowing the original query before.

The fix is trivial, just allow to add AND in AND. The same needs to be done for OR. Patch will follow in a second...

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. DDC-1255 Can't add instance of Andx to QueryBuilder through andWhere

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.
is required for

New Feature - A new feature of the product, which has yet to be developed. DDC-1299 Allow for nested Andx and Orx in QueryBuilder

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guilherme Blanco added a comment -

This can lead to unpredictable situations inside QueryBuilder.
Maybe we can add a "merge" function to Expr\Composite, I'm not sure.

I need to actually test it on every driver to make sure if it doesn't break anything. It was not originally designed to hold same instances. If you pay attention:

((a AND b) AND c)

Is the same as:

a AND b AND c

Can't you make a check internally and use addMultiple?
In the meantime, I can make tests to check if it doesn't break anything else.

Show
Guilherme Blanco added a comment - This can lead to unpredictable situations inside QueryBuilder. Maybe we can add a "merge" function to Expr\Composite, I'm not sure. I need to actually test it on every driver to make sure if it doesn't break anything. It was not originally designed to hold same instances. If you pay attention: ((a AND b) AND c) Is the same as: a AND b AND c Can't you make a check internally and use addMultiple? In the meantime, I can make tests to check if it doesn't break anything else.
Hide
Permalink
Guilherme Blanco added a comment -

In this commit: https://github.com/doctrine/doctrine2/commit/816ce41f638d28934c79a12ef27f954124b2639e
I applied the support to this improvement, since it does not mess with generated code.

Show
Guilherme Blanco added a comment - In this commit: https://github.com/doctrine/doctrine2/commit/816ce41f638d28934c79a12ef27f954124b2639e I applied the support to this improvement, since it does not mess with generated code.

People

  • Assignee:
    Guilherme Blanco
    Reporter:
    Andreas Förthner
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: