On PostgreSQL "doctrine orm:schema-tool:drop --force" will not delete all tables created by orm:schema-tool:create and still report success

I changed alot in the dropSchema command, can you try again? The problem here is with all the foreign keys.

Ok, thanks.

I tried again, now with Doctrine version 2.04.

I updated the Doctrine 2 installation to version 2.04, then recreated the complete database from scratch using doctrine orm:schema-tool:create --force.
Before recreating the database, I manually, dropped all tables in the database, and verified all tables were gone. I also regenerated the proxy classes, just in case it could have any effect.

The 86 tables have been created, as expected.

Then I tried to drop the database by calling doctrine orm:schema-tool:drop --force.

After using the command, there are still 17 tables remaining.

Overall, the result seems to be unaffected by the upgrade to the latest minor version.

One thing that works now, though, is that calling doctrine orm:schema-tool:drop --force repeatedly, will also delete the 17 tables remaining after the first call.

So it did get better, although it does not work the first time it gets called, and still wrongly reports success the first time.

This should be fixed now, SchemaTool didnt handle sequence removal correctly before. Can you verify?

Hey Ben,

I am currently travelling and do not have access to any development system. I will be back home by July, 1st and will have a look at this and let you know. Thanks for fixing it.

maybe it's related to this bug : http://www.doctrine-project.org/jira/browse/DDC-1266

I just found this piece of code that mutes exceptions...

    public function dropSchema(array $classes)
    {
        $dropSchemaSql = $this->getDropSchemaSQL($classes);
        $conn = $this->_em->getConnection();

        foreach ($dropSchemaSql as $sql) {
            try {
                $conn->executeQuery($sql);
            } catch(\Exception $e) {
                
            }
        }
    }

maybe I'm missing something but even after reading the function comment this seems like a bad idea.
if dropTable is called within a transaction, the transaction will be aborted and the function will still return as if sucessful

@Mathieu: Yes, that could very well be the root cause.

@Benjamin: I verified that the error is still there, now with Doctrine 2.1 and PostgreSQL 8.4. The command line tool (doctrine orm:schema-tool:drop --force) still wrongly reports success, in spite of several tables remaining in the schema.

Once I remove the try-catch-construct mentioned by Mathieu above (leaving the try block's content intact, of course), and reissue the command, there are exceptions. E.g.:

PDOException SQLSTATE[42P01]: Undefined table: 7 ERROR: sequence "some_random_sequence_seq" does not exist.

I believe that the intention of the try-catch-block above is to mute exactly that type of error, since it should not make any difference if something that is not there could not be deleted, because, after all, it is gone anyway. Unfortunately, it actually does make a difference in case several SQL-DDL commands are combined into a single call, because if any command in the call fails and raises an exception, all following commands in the same call will not be executed. I have not analyzed this further, but I think there is something smelly here.

Fixed