Doctrine 2 - ORM

Transitive persistence broken

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0-ALPHA3
  • Component/s: ORM
  • Security Level: All
  • Labels:
    None

Description

When cascading 'persist' operations, the object which was not persisted implicitly is being written to the DB with wrong parameters, broken SQL:

INSERT INTO email (email, userId) VALUES (?, ?)
array(3) {
  [1]=>
  NULL
  [2]=>
  string(16) "user@example.com"
  [3]=>
  int(1)
}

See the attached example for details... When I uncomment the "$em->persist($email);" line, everything works as expected (but I'd like this persist to be done automatically...)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roman S. Borschel added a comment -

Indeed this looks like a bug, but it is unrelated to cascades.

I will explain on your code sample:

$em = EntityManager::create($connectionOptions, $config);
$user = new \Entity\User;
$user->setName('Bob');

// This would invoke persist() on the associated email because of the cascade, but there is no email yet!
// After persist() $user is MANAGED
$em->persist($user);

$email = new \Entity\Email;
$email->setEmail('user@example.com');
$user->addEmails($email);

// On flush the email should be correctly persisted because it is NEW but referenced/reachable from a MANAGED entity ($user)
$em->flush();

Just to clarify. So this is a bug in the "persistence by reachability".

"persistence by reachability" means that a NEW entity (like $email) that is associated to a MANAGED entity (like $user) and the association has cascade=persist is automatically persisted on flush().

I still need to write about persistence by reachability in the manual but as you have already found out, it is intuitive since you expect that to happen.

Show
Roman S. Borschel added a comment - Indeed this looks like a bug, but it is unrelated to cascades. I will explain on your code sample: $em = EntityManager::create($connectionOptions, $config); $user = new \Entity\User; $user->setName('Bob'); // This would invoke persist() on the associated email because of the cascade, but there is no email yet! // After persist() $user is MANAGED $em->persist($user); $email = new \Entity\Email; $email->setEmail('user@example.com'); $user->addEmails($email); // On flush the email should be correctly persisted because it is NEW but referenced/reachable from a MANAGED entity ($user) $em->flush(); Just to clarify. So this is a bug in the "persistence by reachability". "persistence by reachability" means that a NEW entity (like $email) that is associated to a MANAGED entity (like $user) and the association has cascade=persist is automatically persisted on flush(). I still need to write about persistence by reachability in the manual but as you have already found out, it is intuitive since you expect that to happen.
Hide
Permalink
Roman S. Borschel added a comment -

Ok its not completely unrelated to cascades since persistence by reachability still requires cascade=persist but the bug itself has to do with incorrect changeset calculation.

Show
Roman S. Borschel added a comment - Ok its not completely unrelated to cascades since persistence by reachability still requires cascade=persist but the bug itself has to do with incorrect changeset calculation.

People

  • Assignee:
    Roman S. Borschel
    Reporter:
    Nico Kaiser
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: