Doctrine 2 - ORM

renaming "load()" in proxy to "__load()"

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: Git Master
  • Fix Version/s: 2.1
  • Component/s: ORM
  • Security Level: All
  • Labels:
    None

Description

It would be really great if the method "load" is renamed to something more protected like "__load" or "_doctrineOdmLoad" like it has done for public properties
public $__dm;
public $__identifier;
public $isInitialized = false;
Because otherwise if a referenced document has the same method "load" it causes error like this

"Fatal error: Cannot redeclare Proxies\ProjectProxy::load() in /projects/tbi_doctrine/tmp/doctrine/proxies/ProjectProxy.php on line 46"

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. MODM-118 rename "load" method in Proxy object to "__load__"

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jonathan H. Wage added a comment -

This issue is a duplicate of another issue in the ODM. The fix applies to the ORM as well.

Show
Jonathan H. Wage added a comment - This issue is a duplicate of another issue in the ODM. The fix applies to the ORM as well.
Hide
Permalink
Guilherme Blanco added a comment -

Fixed on master

https://github.com/doctrine/doctrine2/commit/e5381286458ac467543b23ac1a1a1c613bbc2ff1

Show
Guilherme Blanco added a comment - Fixed on master https://github.com/doctrine/doctrine2/commit/e5381286458ac467543b23ac1a1a1c613bbc2ff1

People

  • Assignee:
    Guilherme Blanco
    Reporter:
    Jonathan H. Wage
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: