Doctrine Common

Annotation mapper tries to parse PHPDocblock annotations

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.0.0-BETA2
  • Fix Version/s: 2.0.0-BETA3
  • Component/s: None
  • Labels:
    None
  • Environment:
    OS: Ubuntu, PHP version: 5.3.2

Description

In the upgrade from DC2 beta1 to beta2 the annonation mapper now starts to try and parse a some of the PHPDocblock annotations such as @package @subpackage but also the email adress in @author

Example of docblock

/**
 * @author Antoine Hedgecock <antoine@pmg.se>
 * @version 1.0.0
 */


/**
 * @package Models
 * @subpackage Default
 * 
 * @Entity(repositoryClass="Default_Model_Mapper_Category")
 * @Table(name="categories")
 * @InheritanceType("SINGLE_TABLE")
 * @DiscriminatorColumn(name="type", type="smallint")
 * @DiscriminatorMap({
 *  "0" = "Project_Model_Category"
 * })
 */

will cause it to try and load

Doctrine/ORM/Mapping/package.php
Doctrine/ORM/Mapping/subpackage.php
Doctrine/ORM/Mapping/pmg.php

note pmg because its in the email of the author annotation

Activity

Ascending order - Click to sort in descending order
Antoine Hedgecock made changes -
Field Original Value New Value
Description In the upgrade from DC2 beta1 to beta2 the annonation mapper now starts to try and parse a some of the PHPDocblock annotations such as @package @subpackage but also the email adress in @author

Example of docblock

{code:php}
<?php
/**
 * @author Antoine Hedgecock <antoine@pmg.se>
 * @version 1.0.0
 */


/**
 * @package Models
 * @subpackage Default
 *
 * @Entity(repositoryClass="Default_Model_Mapper_Category")
 * @Table(name="categories")
 * @InheritanceType("SINGLE_TABLE")
 * @DiscriminatorColumn(name="type", type="smallint")
 * @DiscriminatorMap({
 * "0" = "Project_Model_Category"
 * })
 */
{code}

will cause it to try and load
{quote}
Doctrine/ORM/Mapping/package.php
Doctrine/ORM/Mapping/subpackage.php
Doctrine/ORM/Mapping/pm.php
{quote} 		In the upgrade from DC2 beta1 to beta2 the annonation mapper now starts to try and parse a some of the PHPDocblock annotations such as @package @subpackage but also the email adress in @author

Example of docblock

{code:java}
/**
 * @author Antoine Hedgecock <antoine@pmg.se>
 * @version 1.0.0
 */


/**
 * @package Models
 * @subpackage Default
 *
 * @Entity(repositoryClass="Default_Model_Mapper_Category")
 * @Table(name="categories")
 * @InheritanceType("SINGLE_TABLE")
 * @DiscriminatorColumn(name="type", type="smallint")
 * @DiscriminatorMap({
 * "0" = "Project_Model_Category"
 * })
 */
{code}

will cause it to try and load
{quote}
Doctrine/ORM/Mapping/package.php
Doctrine/ORM/Mapping/subpackage.php
Doctrine/ORM/Mapping/pm.php
{quote}
Antoine Hedgecock made changes -
Description In the upgrade from DC2 beta1 to beta2 the annonation mapper now starts to try and parse a some of the PHPDocblock annotations such as @package @subpackage but also the email adress in @author

Example of docblock

{code:java}
/**
 * @author Antoine Hedgecock <antoine@pmg.se>
 * @version 1.0.0
 */


/**
 * @package Models
 * @subpackage Default
 *
 * @Entity(repositoryClass="Default_Model_Mapper_Category")
 * @Table(name="categories")
 * @InheritanceType("SINGLE_TABLE")
 * @DiscriminatorColumn(name="type", type="smallint")
 * @DiscriminatorMap({
 * "0" = "Project_Model_Category"
 * })
 */
{code}

will cause it to try and load
{quote}
Doctrine/ORM/Mapping/package.php
Doctrine/ORM/Mapping/subpackage.php
Doctrine/ORM/Mapping/pm.php
{quote} 		In the upgrade from DC2 beta1 to beta2 the annonation mapper now starts to try and parse a some of the PHPDocblock annotations such as @package @subpackage but also the email adress in @author

Example of docblock

{code:java}
/**
 * @author Antoine Hedgecock <antoine@pmg.se>
 * @version 1.0.0
 */


/**
 * @package Models
 * @subpackage Default
 *
 * @Entity(repositoryClass="Default_Model_Mapper_Category")
 * @Table(name="categories")
 * @InheritanceType("SINGLE_TABLE")
 * @DiscriminatorColumn(name="type", type="smallint")
 * @DiscriminatorMap({
 * "0" = "Project_Model_Category"
 * })
 */
{code}

will cause it to try and load
{quote}
Doctrine/ORM/Mapping/package.php
Doctrine/ORM/Mapping/subpackage.php
Doctrine/ORM/Mapping/pmg.php
{quote}

note pmg because its in the email of the author annotation
Hide
Permalink
Roman S. Borschel added a comment -

Please try with the latest version of Doctrine Common http://github.com/doctrine/common

See also DCOM-8

Show
Roman S. Borschel added a comment - Please try with the latest version of Doctrine Common http://github.com/doctrine/common See also DCOM-8
Roman S. Borschel made changes -
Project Doctrine 2 - ORM [ 10032 ] Doctrine Common [ 10043 ]
Key DDC-643 DCOM-9
Affects Version/s 2.0.0-BETA2 [ 10061 ]
Affects Version/s 2.0-BETA2 [ 10050 ]
Component/s Mapping Drivers [ 10044 ]
Hide
Permalink
Antoine Hedgecock added a comment -

After comparing the source code version i found the following changes that could cause the issue

Line 249 in Beta2

$this->lexer->lookahead != null && ! $this->lexer->isNextToken(Lexer::T_OPEN_PARENTHESIS) && ! ClassLoader::classExists($name)
Show
Antoine Hedgecock added a comment - After comparing the source code version i found the following changes that could cause the issue Line 249 in Beta2 $ this ->lexer->lookahead != null && ! $ this ->lexer->isNextToken(Lexer::T_OPEN_PARENTHESIS) && ! ClassLoader ::classExists($name)
Hide
Permalink
Roman S. Borschel added a comment -

Fixed in the beta3 release that is already out now.

Show
Roman S. Borschel added a comment - Fixed in the beta3 release that is already out now.
Roman S. Borschel made changes -
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s 2.0.0-BETA3 [ 10069 ]
Resolution Fixed [ 1 ]
Benjamin Eberlei made changes -
Workflow jira [ 11504 ] jira-feedback2 [ 17936 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 17936 ] jira-feedback3 [ 19899 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DCOM-9, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Roman S. Borschel
    Reporter:
    Antoine Hedgecock
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: