Doctrine Common

Extract a common ProxyFactory

Details

  • Type: New Feature New Feature
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.4
  • Component/s: None
  • Labels:
    None

Description

Currently, each Doctrine project implements its own ProxyFactory. But the most part of the logic is simply copy-pasted from the ORM implementation (or from an older version of the ORM implementation). Extracting the common code would be a good idea to avoid having to maintain 4 places (or even more) containing the same logic

Activity

Ascending order - Click to sort in descending order
Benjamin Eberlei made changes -
Field Original Value New Value
Workflow jira [ 13435 ] jira-feedback2 [ 17863 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 17863 ] jira-feedback3 [ 19826 ]
Marco Pivetta made changes -
Assignee Benjamin Eberlei [ beberlei ] Marco Pivetta [ ocramius ]
Hide
Permalink
Marco Pivetta added a comment -

I have a working implementation of public properties lazy loading at https://github.com/Ocramius/doctrine2/compare/master...DCOM-96-restarted

I am still trying to figure out performance issues, since this PR adds 5% overhead on top of Hydrators/Persisters/UnitOfWork, since it turned out that 

$reflectionProperty->getValue($object);

actually triggers PHP's magic __get method.
I've worked this around by assuming nulls when values are not set, but this adds some conditionals that obviously slow down all the extraction of values process.

Show
Marco Pivetta added a comment - I have a working implementation of public properties lazy loading at https://github.com/Ocramius/doctrine2/compare/master...DCOM-96-restarted I am still trying to figure out performance issues, since this PR adds 5% overhead on top of Hydrators/Persisters/UnitOfWork, since it turned out that $reflectionProperty->getValue($object); actually triggers PHP's magic __get method. I've worked this around by assuming nulls when values are not set, but this adds some conditionals that obviously slow down all the extraction of values process.
Marco Pivetta made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 2.4 [ 10327 ]
Resolution Fixed [ 1 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DCOM-96, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Marco Pivetta
    Reporter:
    Christophe Coevoet
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: