Doctrine Common

Add Reflection Abstraction

Details

  • Type: New Feature New Feature
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.2
  • Component/s: None
  • Labels:
    None

Description

The Reflection code in ClassMetadata(Info*)s is getting out of control.

I want to remove the dependency by introducing a ReflectionService interface:

interface ReflectionService
{
    public function getClassShortName($class);
    public function getClassNamespace($class);
    public function getClass($class);
    public function getAccessibleProperty($class, $property);
    public function hasPublicMethod($class, $method);
}

The reflection methods are specifically allowed to return NULL, so that we can create a StaticReflectionService that works without the classes actually existing.

Issue Links

is referenced by

Improvement - An improvement or enhancement to an existing feature or task. DDC-1577 Remove static Reflection dependency from ClassMetadata

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Eberlei added a comment -

This issue is referenced in Github Pull-Request GH-89
https://github.com/doctrine/common/pull/89

Show
Benjamin Eberlei added a comment - This issue is referenced in Github Pull-Request GH-89 https://github.com/doctrine/common/pull/89
Hide
Permalink
Benjamin Eberlei added a comment -

Related Pull Request was closed: https://github.com/doctrine/common/pull/89

Show
Benjamin Eberlei added a comment - Related Pull Request was closed: https://github.com/doctrine/common/pull/89
Hide
Permalink
Benjamin Eberlei added a comment -

Implemented

Show
Benjamin Eberlei added a comment - Implemented
Benjamin Eberlei made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Benjamin Eberlei made changes -
Link This issue is referenced by DDC-1577 [ DDC-1577 ]
Benjamin Eberlei made changes -
Workflow jira [ 13317 ] jira-feedback2 [ 17927 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 17927 ] jira-feedback3 [ 19890 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DCOM-93, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Benjamin Eberlei
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: